Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/gorilla/websocket to address CVE-2020-27813. #2195

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Addresses CVE-2020-27813.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0fa4c180-2ae5-4020-bc82-51f25132a4b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it might just be some flakiness in the sdk conformance tests. But if you can resolve the conflict, we can run this again.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@roberthbailey
Copy link
Member Author

Think it might just be some flakiness in the sdk conformance tests. But if you can resolve the conflict, we can run this again.

Done. Let's see if the tests pass this time.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e394268f-ce47-44ab-8505-62b7940c3e65

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2195/head:pr_2195 && git checkout pr_2195
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-7e3d588

@markmandel markmandel merged commit d3b9d6b into googleforgames:main Jul 27, 2021
@markmandel markmandel added this to the 1.17.0 milestone Jul 27, 2021
@markmandel markmandel added the area/security Issues pertaining to security label Jul 27, 2021
@roberthbailey roberthbailey deleted the gorilla/websocket branch September 23, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants