Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto and allocator for advanced allocation #2199

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Update proto and allocator for advanced allocation #2199

merged 3 commits into from
Jul 28, 2021

Conversation

markmandel
Copy link
Member

@markmandel markmandel commented Jul 27, 2021 •
edited by roberthbailey
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Update the proto for allocation and related converters to allow advanced allocation to also occur through the Allocation endpoint, and not just the GameServerAllocation CRD.

This has been tested for backward compatability with the previous proto version (ran allocation e2e from main branch against an install of this PR).

Which issue(s) this PR fixes:

Work on #1239

Special notes for your reviewer:

The only outstanding item for #1239 is updates to the documentation!

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 27, 2021
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@markmandel
Copy link
Member Author

/cc @ilkercelikyilmaz please take a look!

I've tested the proto changes for backward compatibility (see comment above), but would be good to get your extra eyes on this!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fa427307-126b-4cf9-b3d3-1b20ff81ac32

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Helm got stuck in "pending-upgrade" - that's a new one. Might be time to update helm as well.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7c060524-1992-44e5-a057-bedd05fb40ca

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b8960fb1-121d-48c2-9f1d-0b69886b84f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 889d0486-5f42-41b9-8c5f-c13e3cce1a8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2199/head:pr_2199 && git checkout pr_2199
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-1ac724d

roberthbailey
roberthbailey reviewed Jul 28, 2021
View reviewed changes
pkg/allocation/converters/converter.go Show resolved Hide resolved
pkg/allocation/converters/converter_test.go Outdated Show resolved Hide resolved
proto/allocation/allocation.proto Outdated Show resolved Hide resolved
proto/allocation/allocation.proto Show resolved Hide resolved
@markmandel
Update proto and allocator for advanced allocation
327b137 
Update the proto for allocation and related converters to allow advanced
allocation to also occur through the Allocation endpoint, and not just
the `GameServerAllocation` CRD.

This has been tested for backward compatability with the previous proto
version (ran allocation e2e from `main` branch against an install of
this PR).

The only outstanding item for googleforgames#2148 is updates to the documentation!

Work on googleforgames#2148
@markmandel
Review updates.
c816d6d
@markmandel markmandel force-pushed the feature/advanced-allocation-api branch from 1ac724d to c816d6d Compare July 28, 2021 18:42
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6c53b2c3-d687-44f6-8d8d-b660c165fbd6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2199/head:pr_2199 && git checkout pr_2199
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-c816d6d

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f1debef-ec31-4c47-914e-06eb8483c2cd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2199/head:pr_2199 && git checkout pr_2199
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-dac824e

@roberthbailey roberthbailey merged commit f0659a0 into googleforgames:main Jul 28, 2021
@markmandel markmandel deleted the feature/advanced-allocation-api branch July 28, 2021 20:53
@roberthbailey roberthbailey added this to the 1.17.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@ilkercelikyilmaz ilkercelikyilmaz Awaiting requested review from ilkercelikyilmaz

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/feature New features for Agones size/XL
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey