-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools - vetshadow is more aggressive #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the latest vetshadow seems to be far more aggressive with the newer version. So updating the build image, and fixing all the issues.
markmandel
added
kind/cleanup
Refactoring code, fixing up documentation, etc
area/build-tools
Development tooling. I.e. pretty much everything in the `build` directory.
labels
May 24, 2018
Build Failed 😱 Build Id: 8fb2dc1e-9f1b-44ad-ad43-ee9bac8ab0be Build Logs
|
This may need to wait until #221 is merged, and can be updated into this branch. 100s may not be long enough. |
EricFortin
approved these changes
May 24, 2018
Build Succeeded 👏 Build Id: 70cf4038-08fb-41ec-ab91-81e2bb878d81 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build-tools
Development tooling. I.e. pretty much everything in the `build` directory.
kind/cleanup
Refactoring code, fixing up documentation, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the latest vetshadow seems to be far more aggressive with the newer version.
So updating the build image, and fixing all the issues.