Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for bullseye release CI blockage #2225

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Workaround for bullseye release CI blockage #2225

merged 2 commits into from
Aug 18, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Switch out apt-get update commands that are run in CI to being apt-get --allow-releaseinfo-change update to ignore the error on new release change.

Which issue(s) this PR fixes:

Workaround for #2224 until we can upgrade everything to bullseye.

Special notes for your reviewer:

🤞🏻

@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Aug 17, 2021
@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c6358771-ba02-497d-907b-e25e83b08f20

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Workaround for bullseye release CI blockage
69ada6c 
Switch out `apt-get update` commands that are run in CI to being
`apt-get --allow-releaseinfo-change update` to ignore the error on new
release change.

Workaround for googleforgames#2224 until we can upgrade everything to bullseye.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 519014a1-97cb-4fe1-a521-bbb4fbb3d002

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Looks like the workaround worked, but got caught here instead:

✘✘✘ failed in 394.534443ms
1 errors in 135 documents
Html Test: Attempt 20
htmltest started at 10:23:54 on /tmp/website
========================================================================
site/index.html
  Non-OK status: 403 --- site/index.html --> https://vela.games/
========================================================================

Which is weird, since I can open the url from here just fine. Will retry.

@markmandel
Copy link
Member Author

markmandel commented Aug 17, 2021 •
edited
Loading

Ah, Vela is giving us a CloudFlare 403. I'll add a data-proofer-ignore for now. I can replicate with curl.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c0984a01-889d-416a-96d0-d951611f12e4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@cindy52
Copy link
Contributor

cindy52 commented Aug 18, 2021

Ah, Vela is giving us a CloudFlare 403. I'll add a data-proofer-ignore for now. I can replicate with curl.

Thank you Mark! I kept getting the hugo-test error before locally. I will merger your fix to my branch!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

Looks like a flake:

``
time="2021-08-17 23:41:16.105" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-qjmd5
--- FAIL: TestAutoscalerBasicFunctions (331.46s)
fleetautoscaler_test.go:81: error waiting for fleet condition on fleet simple-fleet-qjmd5

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8235d346-bd8d-436f-8746-697859ce6dcb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

I can't see why the last build failed 🤔 looks like everything passed on the test step, as far as I can see

@markmandel
Copy link
Member Author

Aha found it!

+ apt-get update
Get:1 http://deb.debian.org/debian buster InRelease [122 kB]
Get:2 http://deb.debian.org/debian buster-updates InRelease [51.9 kB]
Get:3 http://security.debian.org/debian-security buster/updates InRelease [65.4 kB]
Reading package lists...
E: Repository 'http://deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'stable' to 'oldstable'
E: Repository 'http://deb.debian.org/debian buster-updates InRelease' changed its 'Suite' value from 'stable-updates' to 'oldstable-updates'
E: Repository 'http://security.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'stable' to 'oldstable'
Error executing command, exiting
includes/sdk.mk:106: recipe for target 'build-build-sdk-image' failed

@markmandel
Add data-proofer-ignore to vela.games
3a850ec 
Getting a cloudflare 403 captcha with this url.
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel
Copy link
Member Author

Think I got it this time. The nodejs installation script was calling apt-get update.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a5563ec7-102a-4bf9-b702-5b9081b96c5a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2225/head:pr_2225 && git checkout pr_2225
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-3a850ec

@markmandel markmandel merged commit 07fbf67 into googleforgames:main Aug 18, 2021
@markmandel markmandel deleted the ci/fix-release-breakage branch August 18, 2021 18:33
@markmandel markmandel added this to the 1.17.0 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/bug These are bugs. size/S
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @cindy52 @google-oss-robot @roberthbailey