Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some missing tasks in the release #224

Merged
merged 2 commits into from
May 26, 2018
Merged

Some missing tasks in the release #224

merged 2 commits into from
May 26, 2018

Conversation

markmandel
Copy link
Member

Realised there were a couple of steps missing from the release checklist.

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label May 24, 2018
@markmandel markmandel added this to the 0.2.0 milestone May 24, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8ac929aa-9bb3-4ca5-a63f-4fc3a9724e44

The following development artifacts have been built, and will exist for the next 30 days:

@markmandel
Some missing tasks in the release
7979ed0 
Realised there were a couple of steps missing
from the release checklist.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2af4d3e7-ebf2-4f2b-831c-501f6db7c31a

The following development artifacts have been built, and will exist for the next 30 days:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1e1e254c-f810-4e2a-a410-b6acf20a74d4

Build Logs 
starting build "1e1e254c-f810-4e2a-a410-b6acf20a74d4"

FETCHSOURCE
Initialized empty Git repository in /workspace/.git/
From https://source.developers.google.com/p/agones-images/r/agones
 * branch            9bf13b176be8f61538511682e0e0db9d159f52d0 -> FETCH_HEAD
HEAD is now at 9bf13b1 Merge branch 'master' into docs/missing-release-tasks
BUILD
Starting Step #0
Step #0: Already have image (with digest): ubuntu
Finished Step #0
Starting Step #1
Step #1: Already have image (with digest): gcr.io/cloud-builders/docker
Step #1: Sending build context to Docker daemon  131.1MB

Step #1: Step 1/3 : FROM gcr.io/cloud-builders/docker
Step #1:  ---> 4ffaef331b2e
Step #1: Step 2/3 : RUN apt-get install make
Step #1:  ---> Running in e80a6ac69738
Step #1: Reading package lists...
Step #1: Building dependency tree...
Step #1: Reading state information...
Step #1: Suggested packages:
Step #1:   make-doc
Step #1: The following NEW packages will be installed:
Step #1:   make
Step #1: 0 upgraded, 1 newly installed, 0 to remove and 3 not upgraded.
Step #1: Need to get 151 kB of archives.
Step #1: After this operation, 365 kB of additional disk space will be used.
Step #1: Get:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 make amd64 4.1-6 [151 kB]
Step #1: Fetched 151 kB in 0s (250 kB/s)
Step #1: Selecting previously unselected package make.
Step #1: (Reading database ... 
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 11239 files and directories currently installed.)
Step #1: Preparing to unpack .../archives/make_4.1-6_amd64.deb ...
Step #1: Unpacking make (4.1-6) ...
Step #1: Setting up make (4.1-6) ...
Step #1: Removing intermediate container e80a6ac69738
Step #1:  ---> 68508fba814c
Step #1: Step 3/3 : ENTRYPOINT ["/usr/bin/make"]
Step #1:  ---> Running in 06bae5094f10
Step #1: Removing intermediate container 06bae5094f10
Step #1:  ---> 7dbeb713ea5a
Step #1: Successfully built 7dbeb713ea5a
Step #1: Successfully tagged make-docker:latest
Finished Step #1
Starting Step #2
Step #2: Already have image: make-docker
Step #2: docker pull gcr.io/agones-images/agones-build:77fc9af031 && docker tag gcr.io/agones-images/agones-build:77fc9af031 agones-build:77fc9af031
Step #2: 77fc9af031: Pulling from agones-images/agones-build
Step #2: c73ab1c6897b: Pulling fs layer
Step #2: 3091fac74ac3: Pulling fs layer
Step #2: 32ec8f15f1df: Pulling fs layer
Step #2: fac055c60f68: Pulling fs layer
Step #2: a59c15b8d483: Pulling fs layer
Step #2: 34efcc4fdf91: Pulling fs layer
Step #2: 84ff1f9b2468: Pulling fs layer
Step #2: 5168a6f2412d: Pulling fs layer
Step #2: 420eed74c2aa: Pulling fs layer
Step #2: 6f7712add452: Pulling fs layer
Step #2: dab7d4cc975f: Pulling fs layer
Step #2: 4c5943cfa1cc: Pulling fs layer
Step #2: a6abe2d36daf: Pulling fs layer
Step #2: 1c18bc879056: Pulling fs layer
Step #2: 8492be485b78: Pulling fs layer
Step #2: 55271adb1570: Pulling fs layer
Step #2: fac055c60f68: Waiting
Step #2: a59c15b8d483: Waiting
Step #2: 34efcc4fdf91: Waiting
Step #2: 84ff1f9b2468: Waiting
Step #2: 5168a6f2412d: Waiting
Step #2: 420eed74c2aa: Waiting
Step #2: 6f7712add452: Waiting
Step #2: dab7d4cc975f: Waiting
Step #2: 4c5943cfa1cc: Waiting
Step #2: a6abe2d36daf: Waiting
Step #2: 1c18bc879056: Waiting
Step #2: 8492be485b78: Waiting
Step #2: 55271adb1570: Waiting
Step #2: c73ab1c6897b: Verifying Checksum
Step #2: c73ab1c6897b: Download complete
Step #2: fac055c60f68: Verifying Checksum
Step #2: fac055c60f68: Download complete
Step #2: c73ab1c6897b: Pull complete
Step #2: 3091fac74ac3: Verifying Checksum
Step #2: 3091fac74ac3: Download complete
Step #2: a59c15b8d483: Verifying Checksum
Step #2: a59c15b8d483: Download complete
Step #2: 34efcc4fdf91: Verifying Checksum
Step #2: 34efcc4fdf91: Download complete
Step #2: 5168a6f2412d: Verifying Checksum
Step #2: 5168a6f2412d: Download complete
Step #2: 420eed74c2aa: Verifying Checksum
Step #2: 420eed74c2aa: Download complete
Step #2: 6f7712add452: Verifying Checksum
Step #2: 6f7712add452: Download complete
Step #2: 84ff1f9b2468: Verifying Checksum
Step #2: 84ff1f9b2468: Download complete
Step #2: 4c5943cfa1cc: Verifying Checksum
Step #2: 4c5943cfa1cc: Download complete
Step #2: dab7d4cc975f: Verifying Checksum
Step #2: dab7d4cc975f: Download complete
Step #2: 32ec8f15f1df: Verifying Checksum
Step #2: 32ec8f15f1df: Download complete
Step #2: a6abe2d36daf: Verifying Checksum
Step #2: a6abe2d36daf: Download complete
Step #2: 1c18bc879056: Verifying Checksum
Step #2: 1c18bc879056: Download complete
Step #2: 8492be485b78: Verifying Checksum
Step #2: 8492be485b78: Download complete
Step #2: 55271adb1570: Verifying Checksum
Step #2: 55271adb1570: Download complete
Step #2: 3091fac74ac3: Pull complete
Step #2: 32ec8f15f1df: Pull complete
Step #2: fac055c60f68: Pull complete
Step #2: a59c15b8d483: Pull complete
Step #2: 34efcc4fdf91: Pull complete
Step #2: 84ff1f9b2468: Pull complete
Step #2: 5168a6f2412d: Pull complete
Step #2: 420eed74c2aa: Pull complete
Step #2: 6f7712add452: Pull complete
Step #2: dab7d4cc975f: Pull complete
Step #2: 4c5943cfa1cc: Pull complete
Step #2: a6abe2d36daf: Pull complete
Step #2: 1c18bc879056: Pull complete
Step #2: 8492be485b78: Pull complete
Step #2: 55271adb1570: Pull complete
Step #2: Digest: sha256:a4f90e5ff24d687b9afcfaa1193c0d6f6397422be260d0d1241b6b55ae016d3e
Step #2: Status: Downloaded newer image for gcr.io/agones-images/agones-build:77fc9af031
Finished Step #2
Starting Step #3
Step #3: Already have image: make-docker
Step #3: mkdir -p ~/.kube
Step #3: mkdir -p /workspace/build//.config/gcloud
Step #3: docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube:/root/.kube -v /workspace:/go/src/agones.dev/agones -w /go/src/agones.dev/agones  agones-build:77fc9af031 bash -c \
Step #3: 	"/root/gen-lint-exclude.sh && gometalinter --config .exclude.gometalinter.json --deadline=5m -t --skip vendor ./..."
Step #3: fatal error: runtime: out of memory
Step #3: 
Step #3: runtime stack:
Step #3: runtime.throw(0x67e62a, 0x16)
Step #3: 	/usr/local/go/src/runtime/panic.go:619 +0x81
Step #3: runtime.sysMap(0xc421260000, 0x100000, 0x0, 0x7f1e18)
Step #3: 	/usr/local/go/src/runtime/mem_linux.go:216 +0x20a
Step #3: runtime.(*mheap).sysAlloc(0x7d9660, 0x100000, 0x0)
Step #3: 	/usr/local/go/src/runtime/malloc.go:470 +0xd4
Step #3: runtime.(*mheap).grow(0x7d9660, 0x20, 0x0)
Step #3: 	/usr/local/go/src/runtime/mheap.go:907 +0x60
Step #3: runtime.(*mheap).allocSpanLocked(0x7d9660, 0x20, 0x7f1e28, 0xc420107680)
Step #3: 	/usr/local/go/src/runtime/mheap.go:820 +0x301
Step #3: runtime.(*mheap).alloc_m(0x7d9660, 0x20, 0x410101, 0x7fb7c364b0d0)
Step #3: 	/usr/local/go/src/runtime/mheap.go:686 +0x118
Step #3: runtime.(*mheap).alloc.func1()
Step #3: 	/usr/local/go/src/runtime/mheap.go:753 +0x4d
Step #3: runtime.(*mheap).alloc(0x7d9660, 0x20, 0x7fb7c3010101, 0x7fb7c364b0d0)
Step #3: 	/usr/local/go/src/runtime/mheap.go:752 +0x8a
Step #3: runtime.largeAlloc(0x3fe00, 0x7fb7c3640101, 0x433101)
Step #3: 	/usr/local/go/src/runtime/malloc.go:826 +0x94
Step #3: runtime.mallocgc.func1()
Step #3: 	/usr/local/go/src/runtime/malloc.go:721 +0x46
Step #3: runtime.systemstack(0x0)
Step #3: 	/usr/local/go/src/runtime/asm_amd64.s:409 +0x79
Step #3: runtime.mstart()
Step #3: 	/usr/local/go/src/runtime/proc.go:1170
Step #3: 
Step #3: goroutine 156 [running]:
Step #3: runtime.systemstack_switch()
Step #3: 	/usr/local/go/src/runtime/asm_amd64.s:363 fp=0xc420114ca0 sp=0xc420114c98 pc=0x4536d0
Step #3: runtime.mallocgc(0x3fe00, 0x6208e0, 0xc421249b01, 0xc420114d78)
Step #3: 	/usr/local/go/src/runtime/malloc.go:720 +0x8a2 fp=0xc420114d40 sp=0xc420114ca0 pc=0x411862
Step #3: runtime.makeslice(0x6208e0, 0x3fe00, 0x3fe00, 0x4be8ca, 0xc42000e520, 0xc421249bed)
Step #3: 	/usr/local/go/src/runtime/slice.go:61 +0x77 fp=0xc420114d70 sp=0xc420114d40 pc=0x43fcf7
Step #3: bytes.makeSlice(0x3fe00, 0x0, 0x0, 0x0)
Step #3: 	/usr/local/go/src/bytes/buffer.go:230 +0x6d fp=0xc420114db0 sp=0xc420114d70 pc=0x4959dd
Step #3: bytes.(*Buffer).grow(0xc42018a070, 0x200, 0x213)
Step #3: 	/usr/local/go/src/bytes/buffer.go:144 +0x151 fp=0xc420114e00 sp=0xc420114db0 pc=0x495391
Step #3: bytes.(*Buffer).ReadFrom(0xc42018a070, 0x6aba40, 0xc42000e520, 0x7fb7c364e258, 0xc42018a070, 0xc420114e01)
Step #3: 	/usr/local/go/src/bytes/buffer.go:204 +0x48 fp=0xc420114e70 sp=0xc420114e00 pc=0x4957f8
Step #3: io.copyBuffer(0x6ab760, 0xc42018a070, 0x6aba40, 0xc42000e520, 0x0, 0x0, 0x0, 0xc420114f90, 0x5d3e43, 0xc42009af20)
Step #3: 	/usr/local/go/src/io/io.go:386 +0x31a fp=0xc420114ee0 sp=0xc420114e70 pc=0x4902aa
Step #3: io.Copy(0x6ab760, 0xc42018a070, 0x6aba40, 0xc42000e520, 0x404de5, 0xc42001aa80, 0x6a9ab1)
Step #3: 	/usr/local/go/src/io/io.go:362 +0x5a fp=0xc420114f40 sp=0xc420114ee0 pc=0x48ff4a
Step #3: os/exec.(*Cmd).writerDescriptor.func1(0xc42001aa80, 0x432b38)
Step #3: 	/usr/local/go/src/os/exec/exec.go:275 +0x4d fp=0xc420114fa0 sp=0xc420114f40 pc=0x5d63cd
Step #3: os/exec.(*Cmd).Start.func1(0xc42009b600, 0xc42000d140)
Step #3: 	/usr/local/go/src/os/exec/exec.go:396 +0x27 fp=0xc420114fd0 sp=0xc420114fa0 pc=0x5d6447
Step #3: runtime.goexit()
Step #3: 	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc420114fd8 sp=0xc420114fd0 pc=0x456221
Step #3: created by os/exec.(*Cmd).Start
Step #3: 	/usr/local/go/src/os/exec/exec.go:395 +0x5df
Step #3: 
Step #3: goroutine 1 [chan send]:
Step #3: main.runLinters(0xc420145aa0, 0xc420214240, 0x22, 0x22, 0x1, 0xc4201434a0, 0x0, 0x22, 0x22)
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:116 +0xa0a
Step #3: main.main()
Step #3: 	/go/src/github.com/alecthomas/gometalinter/main.go:232 +0x518
Step #3: 
Step #3: goroutine 157 [syscall]:
Step #3: syscall.Syscall6(0xf7, 0x1, 0x615, 0xc4201145d8, 0x1000004, 0x0, 0x0, 0xc420107500, 0xc42001c000, 0xc420114620)
Step #3: 	/usr/local/go/src/syscall/asm_linux_amd64.s:44 +0x5
Step #3: os.(*Process).blockUntilWaitable(0xc420077440, 0x4b8fab, 0xc4200793d8, 0xc4201146d0)
Step #3: 	/usr/local/go/src/os/wait_waitid.go:31 +0x98
Step #3: os.(*Process).wait(0xc420077440, 0x0, 0xc420114730, 0x0)
Step #3: 	/usr/local/go/src/os/exec_unix.go:22 +0x3c
Step #3: os.(*Process).Wait(0xc420077440, 0xc420114790, 0x5d63ef, 0xc42005bb58)
Step #3: 	/usr/local/go/src/os/exec.go:123 +0x2b
Step #3: os/exec.(*Cmd).Wait(0xc42009b600, 0xc4201147b0, 0x432b38)
Step #3: 	/usr/local/go/src/os/exec/exec.go:461 +0x5c
Step #3: main.executeLinter.func1(0xc42009b600, 0xc420044f50, 0xc42001b200)
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:160 +0x2b
Step #3: created by main.executeLinter
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:159 +0x506
Step #3: 
Step #3: goroutine 155 [select]:
Step #3: main.executeLinter(0x27, 0xc42006d2f0, 0xc420146c00, 0x23, 0x40, 0x0, 0x0)
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:165 +0x5b4
Step #3: main.runLinters.func1(0xc42006d2f0, 0xc420157380, 0xc420058230, 0xc4201e33b0, 0x27, 0xc420146c00, 0x23, 0x40)
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:121 +0x60
Step #3: created by main.runLinters
Step #3: 	/go/src/github.com/alecthomas/gometalinter/execute.go:120 +0xa81
Step #3: 
Step #3: goroutine 39 [chan receive, 4 minutes]:
Step #3: main.filterIssuesViaDirectives.func1(0xc4201573e0, 0xc4201d2d00, 0xc420157440)
Step #3: 	/go/src/github.com/alecthomas/gometalinter/directives.go:191 +0x42
Step #3: created by main.filterIssuesViaDirectives
Step #3: 	/go/src/github.com/alecthomas/gometalinter/directives.go:190 +0x71
Step #3: make: *** [lint] Error 2
Step #3: Makefile:141: recipe for target 'lint' failed
Finished Step #3
ERROR
ERROR: build step 3 "make-docker" failed: exit status 2

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 876a9923-1152-4161-95ca-4135cfaf4171

The following development artifacts have been built, and will exist for the next 30 days:

@markmandel markmandel merged commit f1d7189 into googleforgames:master May 26, 2018
@markmandel markmandel deleted the docs/missing-release-tasks branch May 26, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena