Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the secrets and volume mounts in the allocator pod when they aren't needed #2277

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

roberthbailey
Copy link
Member

e.g. TLS or mTLS is disabled

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2276

Special notes for your reviewer:

@roberthbailey
Copy link
Member Author

/cc @rcreasey

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4fca28af-bad8-43fe-aebf-8bdce26f68d7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2277/head:pr_2277 && git checkout pr_2277
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-b33559c

Copy link
Collaborator

@rcreasey rcreasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🤘

they aren't needed (e.g. TLS or mTLS is disabled).
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rcreasey, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 764d1fb1-3bad-4fa7-8c8b-4b6d55038ca6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2277/head:pr_2277 && git checkout pr_2277
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-d813ac4

@roberthbailey roberthbailey merged commit 466bc3b into googleforgames:main Sep 29, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 2, 2021
@roberthbailey roberthbailey deleted the skip-volume-mounts branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip volume mounts in the allocator pod if TLS on mTLS is disabled
5 participants