Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the link to look for issues for the release. #2287

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The query for closed issues was starting to return a large number (>130) issues. Scanning through some of the issues past the first page I noticed that while we generally caught recently opened (and closed) issues for a release, there were issues without a milestone for many old releases (1.17, 1.14, and even 1.1) that had been missed using the old link.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 96748512-b420-42ba-b271-798b261f1328

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍🏻

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 79da9a8c-e6a3-44c6-b693-27c2d0fc6f72

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

One day we'll work out why the sdk conformance tests are a bit flaky.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 761e3cc8-bb15-412f-a141-1bec42cbdd54

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2287/head:pr_2287 && git checkout pr_2287
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-b093ca5

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d09f5003-b1d0-47a8-bc3e-73c8b3ac74fa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 13f4c7eb-e131-4b3e-96c0-f28fc35df9c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2287/head:pr_2287 && git checkout pr_2287
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-d1546e3

@markmandel markmandel added this to the 1.18.0 milestone Oct 4, 2021
@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Oct 4, 2021
@markmandel markmandel merged commit fa16013 into googleforgames:main Oct 4, 2021
@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 5, 2021
@roberthbailey roberthbailey deleted the release-issues branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants