Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Add test name to Fleet check #2303

Merged
merged 1 commit into from
Oct 8, 2021
Merged

e2e: Add test name to Fleet check #2303

merged 1 commit into from
Oct 8, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Added the test name to the e2e framework logging around Fleets, so it should hopefully make things a bit easier to debug flaky tests.

Which issue(s) this PR fixes:

Work on #2296

Special notes for your reviewer:

@markmandel
e2e: Add test name to Fleet check
86be24a 
Added the test name to the e2e framework logging around Fleets, so it
should hopefully make things a bit easier to debug flaky tests.

Work on googleforgames#2296
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 8, 2021
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e43cc9db-577d-4d66-8efe-726bb3c6ee8a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 698114ec-1e61-4edd-bb6e-e0b51d15730d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2303/head:pr_2303 && git checkout pr_2303
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-86be24a

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

Since this is just adding logging to tests, I'm going to merge it during the feature freeze.

@roberthbailey roberthbailey merged commit e43f086 into googleforgames:main Oct 8, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 12, 2021
@markmandel markmandel deleted the testing/test-name-logging branch October 12, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey