Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example to the release template for a step that I always have to double check. #2318

Merged

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 19, 2021
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 827e6a8e-c29b-420b-8d29-2ba93807d0cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2318/head:pr_2318 && git checkout pr_2318
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-d86e787

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent change!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b960a584-52a9-4eb4-bb45-5808c1ea7aa0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2318/head:pr_2318 && git checkout pr_2318
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-8887c5f

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bff7e90b-2f7f-4799-8215-4e3d5e425304

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2318/head:pr_2318 && git checkout pr_2318
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-24e6e5b

@roberthbailey roberthbailey merged commit a300d8a into googleforgames:main Oct 19, 2021
@roberthbailey roberthbailey added this to the 1.19.0 milestone Nov 1, 2021
@roberthbailey roberthbailey deleted the release-issue-template branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants