Support Unity Package Manager #2343
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "Agones" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "com.googleforgames.agones", | ||
| "version": "1.18.1", | ||
| "displayName": "Agones Unity SDK", | ||
| "description": "The Unity Gameserver SDK for Agones", | ||
| "unity": "2019.1", | ||
| "author": { | ||
| "name": "Google For Games", | ||
|
There was a problem hiding this comment. The NodeJS and csharp SDKs has the author set to "Google LLC" There was a problem hiding this comment. Regarding semantic versioning - yes it does work. I tried out a -dev append on a separate branch (here) and it functioned as expected. So that shouldn't be a problem. I wasn't sure what to set the version number to, but I assumed that if this PR is accepted it'll go out with the next release. Do you have a way of updating the version number across the repo that I could utilize here? Regarding author name, that has been updated. There was a problem hiding this comment. Please add a new step to the section "Update SDK Package Versions" in https://github.com/googleforgames/agones/blob/main/docs/governance/templates/release_issue.md to bump the version number (we currently have steps for the nodejs and csharp SDKs). You should also add a step near the very end to bump the version after a full release (look for "If full release, change to the Since this will pull from github, it sounds like we don't need to update the "Publish SDK packages" section. There was a problem hiding this comment. Updated 👍 |
||
| "url": "https://github.com/googleforgames/agones" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the version of Unity it works with, or is this the version of Agones it corresponds to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the version of Agones that the package corresponds to.
A complete list of all the properties and their descriptions can be found here: https://docs.unity3d.com/Manual/upm-manifestPkg.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page says that the version must be
MAJOR.MINOR.PATCHbut also says it can follow semantic versioning, which would allow us to have this version match what we use elsewhere, e.g.1.19.0-dev(then1.19.0-rc, then1.19.0, then1.20.0-dev, and so on).Do you know if unity will work correctly with our semantic versioning scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I answered this question in another thread, but just to have the info here as well: I tested this semantic versioning scheme and it is supported.