update on scaler limited to Max #2446

SaitejaTamma · 2022-01-21T17:40:30Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2297

Special notes for your reviewer:

agones-bot · 2022-01-21T17:48:28Z

Build Failed 😱

Build Id: e20db59f-12cc-4031-88ea-a8a138698969

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-01-21T17:56:48Z

Looks like you failed linting!

If you want to locally test linting, you can run make lint.

agones-bot · 2022-01-23T05:07:26Z

Build Succeeded 👏

Build Id: 46d62cc4-5b10-4f48-9a7b-ccd50a4fb0e6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-a725877
image: gcr.io/agones-images/agones-ping:1.21.0-a725877
Linux C++ SDK (build): agonessdk-1.21.0-a725877-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-a725877.zip

A preview of the website (the last 30 builds are retained):

https://a725877-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2446/head:pr_2446 && git checkout pr_2446
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-a725877

agones-bot · 2022-01-23T05:16:12Z

Build Failed 😱

Build Id: e6f21317-95c9-41b6-b71a-18c2e1b5516d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-01-24T18:30:05Z

Build Failed 😱

Build Id: a58bfd26-0144-4e52-a83c-565ce67d47c8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Would be good to unit test this to ensure it (a) does what we expect and (b) we don't break it in the future.

agones-bot · 2022-01-25T01:44:08Z

Build Succeeded 👏

Build Id: 4cf92887-39bd-4fd9-bd54-99bd66e9ca2d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-0c0a074
image: gcr.io/agones-images/agones-ping:1.21.0-0c0a074
Linux C++ SDK (build): agonessdk-1.21.0-0c0a074-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-0c0a074.zip

A preview of the website (the last 30 builds are retained):

https://0c0a074-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2446/head:pr_2446 && git checkout pr_2446
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-0c0a074

agones-bot · 2022-01-25T20:08:19Z

Build Failed 😱

Build Id: 61c83f86-367f-499c-b498-8cf8f47cd663

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-01-25T20:39:11Z

Error: 14 UNAVAILABLE: Connection dropped
    at Object.callErrorFromStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:327:49)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at /go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
    at processTicksAndRejections (internal/process/task_queues.js:79:11)
Emitted 'error' event on ClientReadableStreamImpl instance at:
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:327:28)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at /go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 14,
  details: 'Connection dropped',
  metadata: Metadata { internalRepr: Map {}, options: {} }
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ testSDK: `node ./testSDKClient.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @ testSDK script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-01-25T20_02_53_125Z-debug.log
make[2]: *** [includes/sdk.mk:145: run-sdk-conformance-no-build] Error 1
make[1]: *** [includes/sdk.mk:153: run-sdk-conformance-test] Error 2
make: *** [includes/sdk.mk:159: run-sdk-conformance-test-node] Error 2

Node failing conformance is pretty rare.

pkg/fleetautoscalers/controller.go

agones-bot · 2022-01-25T21:08:37Z

Build Succeeded 👏

Build Id: aae0c50d-0a91-4794-a143-3410236b61b7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-e7100b5
image: gcr.io/agones-images/agones-ping:1.21.0-e7100b5
Linux C++ SDK (build): agonessdk-1.21.0-e7100b5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-e7100b5.zip

A preview of the website (the last 30 builds are retained):

https://e7100b5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2446/head:pr_2446 && git checkout pr_2446
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-e7100b5

Co-authored-by: Mark Mandel <markmandel@google.com>

agones-bot · 2022-01-26T14:48:58Z

Build Failed 😱

Build Id: 98dd3121-2851-44c0-95ba-d25bbe6c4657

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-01-26T15:50:43Z

Build Failed 😱

Build Id: c5a82381-d0f2-4bdc-81bf-b45437be2af6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-01-26T16:31:18Z

Build Succeeded 👏

Build Id: af4a5d18-171b-41ce-8aa5-18c7d37641d0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-9d23a22
image: gcr.io/agones-images/agones-ping:1.21.0-9d23a22
Linux C++ SDK (build): agonessdk-1.21.0-9d23a22-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-9d23a22.zip

A preview of the website (the last 30 builds are retained):

https://9d23a22-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2446/head:pr_2446 && git checkout pr_2446
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-9d23a22

google-oss-prow · 2022-01-27T19:49:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

update on scaler limited to Max

03a174d

SaitejaTamma added the kind/bug These are bugs. label Jan 21, 2022

google-oss-prow bot requested review from aLekSer and dzlier-gcp January 21, 2022 17:40

google-oss-prow bot added the size/XS label Jan 21, 2022

SaitejaTamma requested a review from roberthbailey January 21, 2022 17:40

SaitejaTamma and others added 2 commits January 22, 2022 23:11

error fix

a725877

Merge branch 'main' into Sclling_limited-Max

6232497

Merge branch 'main' into Sclling_limited-Max

0c0a074

markmandel reviewed Jan 25, 2022

View reviewed changes

unit test for the code fix

e7100b5

google-oss-prow bot added size/S and removed size/XS labels Jan 25, 2022

markmandel reviewed Jan 25, 2022

View reviewed changes

pkg/fleetautoscalers/controller.go Outdated Show resolved Hide resolved

Update pkg/fleetautoscalers/controller.go

0f6736b

Co-authored-by: Mark Mandel <markmandel@google.com>

Merge branch 'googleforgames:main' into Sclling_limited-Max

1fce988

code fix Remove some duplication of strings and fixing lint

9d23a22

markmandel approved these changes Jan 27, 2022

View reviewed changes

google-oss-prow bot assigned markmandel Jan 27, 2022

google-oss-prow bot added the lgtm label Jan 27, 2022

markmandel merged commit f17c88e into googleforgames:main Jan 27, 2022

google-oss-prow bot added the approved label Jan 27, 2022

markmandel added this to the 1.21.0 milestone Jan 27, 2022

SaitejaTamma deleted the Sclling_limited-Max branch January 27, 2022 19:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update on scaler limited to Max #2446

update on scaler limited to Max #2446

SaitejaTamma commented Jan 21, 2022

agones-bot commented Jan 21, 2022

markmandel commented Jan 21, 2022

agones-bot commented Jan 23, 2022

agones-bot commented Jan 23, 2022

agones-bot commented Jan 24, 2022

markmandel left a comment

agones-bot commented Jan 25, 2022

agones-bot commented Jan 25, 2022

markmandel commented Jan 25, 2022

agones-bot commented Jan 25, 2022

agones-bot commented Jan 26, 2022

agones-bot commented Jan 26, 2022

agones-bot commented Jan 26, 2022

google-oss-prow bot commented Jan 27, 2022

update on scaler limited to Max #2446

update on scaler limited to Max #2446

Conversation

SaitejaTamma commented Jan 21, 2022

agones-bot commented Jan 21, 2022

markmandel commented Jan 21, 2022

agones-bot commented Jan 23, 2022

agones-bot commented Jan 23, 2022

agones-bot commented Jan 24, 2022

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jan 25, 2022

agones-bot commented Jan 25, 2022

markmandel commented Jan 25, 2022

agones-bot commented Jan 25, 2022

agones-bot commented Jan 26, 2022

agones-bot commented Jan 26, 2022

agones-bot commented Jan 26, 2022

google-oss-prow bot commented Jan 27, 2022