Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for the shutdown signal before having the simple game server exit #2463

Merged

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

I tested both scenarios: connecting with nc and sending the EXIT command and using the automaticShutdownDelaySec flag on the fleet and in both cases the game server exits as expected.

@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 1, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1553eaef-8b2f-4940-aade-ce36345388af

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

sdk-conformance failed:

make[2]: *** [includes/sdk.mk:145: run-sdk-conformance-no-build] Error 1
make[1]: *** [includes/sdk.mk:153: run-sdk-conformance-test] Error 2
make: *** [includes/sdk.mk:156: run-sdk-conformance-test-cpp] Error 2
make: *** Waiting for unfinished jobs....
Shutting down after 10 seconds...
Could not run Shutdown():Connect Failed. Exiting!
terminate called without an active exception
/root/sdktest.sh: line 18:     9 Aborted                 (core dumped) /go/src/agones.dev/agones/test/sdk/cpp/.build/.bin/cpp-simple
make[3]: *** [includes/sdk.mk:88: run-sdk-command] Error 134
{"message":"shutting down sdk server","severity":"info","source":"main","time":"2022-02-02T00:30:40.952275177Z"}
{"message":"Received requests match expected list. Test run was successful","sdkName":"go","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2022-02-02T00:30:40.952424952Z"}
{"error":"http: Server closed","message":"http server closed","severity":"info","source":"main","time":"2022-02-02T00:30:40.952643993Z"}

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fdd40fd5-aa66-427b-9b85-5cc8d3be104e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2463/head:pr_2463 && git checkout pr_2463
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-8e71787

Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilkercelikyilmaz, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 79baa31 into googleforgames:main Feb 2, 2022
@SaitejaTamma SaitejaTamma added this to the 1.21.0 milestone Feb 8, 2022
@roberthbailey roberthbailey deleted the sgs-exit-on-signal branch March 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants