-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for the shutdown signal before having the simple game server exit #2463
Wait for the shutdown signal before having the simple game server exit #2463
Conversation
Build Failed 😱 Build Id: 1553eaef-8b2f-4940-aade-ce36345388af To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
sdk-conformance failed:
|
Build Succeeded 👏 Build Id: fdd40fd5-aa66-427b-9b85-5cc8d3be104e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ilkercelikyilmaz, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
I tested both scenarios: connecting with
nc
and sending theEXIT
command and using theautomaticShutdownDelaySec
flag on the fleet and in both cases the game server exits as expected.