v1.21.0-rc #2470

SaitejaTamma · 2022-02-08T23:48:38Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:
v1.20.0-rc
Which issue(s) this PR fixes:
#2469

Special notes for your reviewer:

sdks/nodejs/package-lock.json

site/content/en/blog/releases/1.21.0-rc.md

Co-authored-by: Mark Mandel <markmandel@google.com>

…to release/1.21.0-rc

agones-bot · 2022-02-09T00:11:01Z

Build Failed 😱

Build Id: 923c26ab-32d7-4b62-a292-2548086370fe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-02-09T00:13:27Z

Build Failed 😱

Build Id: f86187c7-49f6-4a94-80a5-87d99caed440

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-02-09T00:30:25Z

Build Succeeded 👏

Build Id: 2fa9de92-561c-4f1f-995a-098004fe7a92

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-1615d76
image: gcr.io/agones-images/agones-ping:1.21.0-1615d76
Linux C++ SDK (build): agonessdk-1.21.0-1615d76-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-1615d76.zip

A preview of the website (the last 30 builds are retained):

https://1615d76-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2470/head:pr_2470 && git checkout pr_2470
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-1615d76

markmandel

LGTM 👍🏻

Please feel free to merge when you are ready to move on to the next steps. (I think you can? If not, ping me and I will push the button).

roberthbailey

LGTM except for the nodejs package-lock.json file, which needs to be fixed before this PR gets merged.

roberthbailey · 2022-02-09T07:26:26Z

sdks/nodejs/package-lock.json

@@ -2514,6 +2514,51 @@
            "engines": {
                "node": ">=10"
            }
+=======


This file looks like it has merge conflicts in it. Please make sure you are using nodejs 16 when running the command (or alternately just edit the version line by hand).

See #2465

oh shoot, I thought this was fixed last night. Thanks for picking that up, I missed it late at night.

roberthbailey · 2022-02-09T07:33:46Z

site/content/en/blog/releases/1.21.0-rc.md

+
+This is a big bug fix release!
+
+Not only did we fix a tonne of flaky tests (which will make contributing easier), but also solved lots of tricky bugs in the process. This includes fixes to the alpha Fleet Autoscaling custom syncing, as well as quality of life improvements where we now validate `metadata` patches on `GameServerAllocation`.


nit: s/tonne/ton

Is it an imperial ton or metric ton (tonne) though, and in the latter case should we use the SI unit of megagrams instead? :P

https://en.wikipedia.org/wiki/Tonne 😄

agones-bot · 2022-02-10T19:56:50Z

Build Succeeded 👏

Build Id: b5750fb5-8b95-4d72-a789-70e2c72dc585

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.21.0-a0395d9
image: gcr.io/agones-images/agones-ping:1.21.0-a0395d9
Linux C++ SDK (build): agonessdk-1.21.0-a0395d9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.21.0-a0395d9.zip

A preview of the website (the last 30 builds are retained):

https://a0395d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2470/head:pr_2470 && git checkout pr_2470
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-a0395d9

google-oss-prow · 2022-02-10T20:17:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

markmandel · 2022-02-10T20:19:29Z

That looks better 👍🏻

steven-supersolid · 2022-02-11T09:27:50Z

Double checked the package-lock.json and looks good

v1.21.0-rc

11d09c4

SaitejaTamma added the kind/release Checklist for a release label Feb 8, 2022

SaitejaTamma requested review from markmandel, steven-supersolid and roberthbailey February 8, 2022 23:48

google-oss-prow bot added the size/L label Feb 8, 2022

google-oss-prow bot requested a review from cyriltovena February 8, 2022 23:48

markmandel reviewed Feb 8, 2022

View reviewed changes

sdks/nodejs/package-lock.json Outdated Show resolved Hide resolved

site/content/en/blog/releases/1.21.0-rc.md Outdated Show resolved Hide resolved

SaitejaTamma and others added 3 commits February 8, 2022 18:56

Update site/content/en/blog/releases/1.21.0-rc.md

a72460c

Co-authored-by: Mark Mandel <markmandel@google.com>

node package update

be26109

Merge branch 'release/1.21.0-rc' of github.com:SaitejaTamma/agones in…

1615d76

…to release/1.21.0-rc

markmandel approved these changes Feb 9, 2022

View reviewed changes

google-oss-prow bot assigned markmandel Feb 9, 2022

google-oss-prow bot added lgtm approved labels Feb 9, 2022

roberthbailey reviewed Feb 9, 2022

View reviewed changes

updated the lock.json file

a0395d9

google-oss-prow bot removed the lgtm label Feb 10, 2022

roberthbailey approved these changes Feb 10, 2022

View reviewed changes

google-oss-prow bot assigned roberthbailey Feb 10, 2022

google-oss-prow bot added the lgtm label Feb 10, 2022

markmandel merged commit c20053e into googleforgames:main Feb 10, 2022

markmandel added this to the 1.21.0 milestone Feb 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.21.0-rc #2470

v1.21.0-rc #2470

SaitejaTamma commented Feb 8, 2022

agones-bot commented Feb 9, 2022

agones-bot commented Feb 9, 2022

agones-bot commented Feb 9, 2022

markmandel left a comment

roberthbailey left a comment

roberthbailey Feb 9, 2022

markmandel Feb 9, 2022

roberthbailey Feb 9, 2022

steven-supersolid Feb 9, 2022

markmandel Feb 9, 2022

agones-bot commented Feb 10, 2022

google-oss-prow bot commented Feb 10, 2022

markmandel commented Feb 10, 2022

steven-supersolid commented Feb 11, 2022


		This is a big bug fix release!

		Not only did we fix a tonne of flaky tests (which will make contributing easier), but also solved lots of tricky bugs in the process. This includes fixes to the alpha Fleet Autoscaling custom syncing, as well as quality of life improvements where we now validate `metadata` patches on `GameServerAllocation`.

v1.21.0-rc #2470

v1.21.0-rc #2470

Conversation

SaitejaTamma commented Feb 8, 2022

agones-bot commented Feb 9, 2022

agones-bot commented Feb 9, 2022

agones-bot commented Feb 9, 2022

markmandel left a comment

Choose a reason for hiding this comment

roberthbailey left a comment

Choose a reason for hiding this comment

roberthbailey Feb 9, 2022

Choose a reason for hiding this comment

markmandel Feb 9, 2022

Choose a reason for hiding this comment

roberthbailey Feb 9, 2022

Choose a reason for hiding this comment

steven-supersolid Feb 9, 2022

Choose a reason for hiding this comment

markmandel Feb 9, 2022

Choose a reason for hiding this comment

agones-bot commented Feb 10, 2022

google-oss-prow bot commented Feb 10, 2022

markmandel commented Feb 10, 2022

steven-supersolid commented Feb 11, 2022