-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simple-game-server to 0.11 everywhere #2506
Update simple-game-server to 0.11 everywhere #2506
Conversation
This increments the sinmple-game-server because of the bug fixes in the Go SDK. Also updates the e2e test suit, so that we can test the fixes in the Go SDK. Unblocks googleforgames#2503
Build Failed 😱 Build Id: 868e446a-d8c4-466e-8a6a-4f4700a7f50a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
oooh this is a weird one - something stuck / change with pushing docker manifests? step:
|
Ah, may be a red-herring, looks like the message pops up always. Just tested locally, and everything still works.
I think there was a flaky error with the container registry. Going to retry. |
Build Succeeded 👏 Build Id: 1edb1730-e7fd-4a26-bd50-ff66b69cd741 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There are some other places that need updating too, e.g. |
@roberthbailey that is a good point. Lemme update this PR with those changes! |
Updated! |
Build Succeeded 👏 Build Id: a0ea2b97-9382-4f78-a395-4d1e2a363abe The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's much more complete.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
This increments the sinmple-game-server because of the bug fixes in the Go SDK.
Also updates the e2e test suit, so that we can test the fixes in the Go SDK.
Which issue(s) this PR fixes:
Unblocks #2503
Special notes for your reviewer:
Image has been uploaded.