Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-game-server to 0.11 everywhere #2506

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This increments the sinmple-game-server because of the bug fixes in the Go SDK.

Also updates the e2e test suit, so that we can test the fixes in the Go SDK.

Which issue(s) this PR fixes:

Unblocks #2503

Special notes for your reviewer:

Image has been uploaded.

This increments the sinmple-game-server because of the bug fixes in the
Go SDK.

Also updates the e2e test suit, so that we can test the fixes in the Go
SDK.

Unblocks googleforgames#2503
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory area/tests Unit tests, e2e tests, anything to make sure things don't break labels Mar 9, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 868e446a-d8c4-466e-8a6a-4f4700a7f50a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

oooh this is a weird one - something stuck / change with pushing docker manifests?

step: push-images

7e65a6aff1da: Pushed
367c178ee1ad: Pushed
8ad1dbbdee2e: Pushed
1.22.0-dfaf01c-linux_amd64: digest: sha256:fc84f8153b8cc206077cdef22be5a5db9282b1373f33152d4630e68596185030 size: 1160
1.22.0-dfaf01c: digest: sha256:b48b332989b30c2a44208633c1e95a8b84aaca3662794ce2f6777b684503238a size: 1160
# Ensure that the sidecar manifest is removed before creating a new one.
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest rm gcr.io/agones-images/agones-sdk:1.22.0-dfaf01c

Usage:	docker manifest COMMAND

The **docker manifest** command has subcommands for managing image manifests and
manifest lists. A manifest list allows you to use one name to refer to the same image
built for multiple architectures.

To see help for a subcommand, use:

    docker manifest CMD --help

For full details on using docker manifest lists, see the registry v2 specification.

Commands:
  annotate    Add additional information to a local image manifest
  create      Create a local manifest list for annotating and pushing to a registry
  inspect     Display an image manifest, or manifest list
  push        Push a manifest list to a repository

Run 'docker manifest COMMAND --help' for more information on a command.
make: [Makefile:466: push-agones-sdk-image] Error 1 (ignored)

@markmandel
Copy link
Member Author

Ah, may be a red-herring, looks like the message pops up always. Just tested locally, and everything still works.

received unexpected HTTP status: 503 Service Unavailable
make: *** [Makefile:456: push-allocator-image] Error 1

I think there was a flaky error with the container registry. Going to retry.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1edb1730-e7fd-4a26-bd50-ff66b69cd741

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2506/head:pr_2506 && git checkout pr_2506
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-dfaf01c

@roberthbailey
Copy link
Member

Update simple-game-server to 0.11 everywhere

There are some other places that need updating too, e.g. examples/simple-game-server/*.yaml test/load/allocation/grpc/fleet.yaml, examples/fleet.yaml, etc if it's going to be "everywhere". If you want to rename the PR to updating it for the e2e tests, then happy to merge as-is.

@markmandel
Copy link
Member Author

@roberthbailey that is a good point. Lemme update this PR with those changes!

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Mar 10, 2022
@markmandel
Copy link
Member Author

Updated!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a0ea2b97-9382-4f78-a395-4d1e2a363abe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2506/head:pr_2506 && git checkout pr_2506
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-86ac4fc

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much more complete.

@google-oss-prow google-oss-prow bot added the lgtm label Mar 10, 2022
@roberthbailey roberthbailey merged commit dff27fe into googleforgames:main Mar 10, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants