-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.22.0 rc #2519
Release v1.22.0 rc #2519
Conversation
Build Failed 😱 Build Id: efac5650-d735-44e9-89df-79d41f345f1a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR doesn't look right. It has a commit for "static TCPUDP support for the container ports" in it which should be a separate PR (and was in #2505). Can you make sure that this PR is just a single commit for the RC changes on top of the main branch? |
Build Failed 😱 Build Id: d6f84c3d-7808-4237-89c0-8779dceebaf2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
08a31b6
to
683c4f9
Compare
Build Failed 😱 Build Id: 24831f12-59d2-47d8-ae63-6b6cdd9b0416 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
683c4f9
to
448b5bb
Compare
Build Failed 😱 Build Id: d5c003de-5304-4a7e-b137-60e5268782cc To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
It looks like you need to re-generate install.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments on the 1.22.0-rc blog post page.
Build Succeeded 👏 Build Id: 62fdc4ac-4975-47a0-9b98-dd74e2436e9e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 07906804-985b-4a71-83c6-3f9015ede086 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
**Implemented enhancements:** | ||
|
||
- Add a multi-cluster allocation example solution to leverage GCP resources to connect to multiple Agones clusters [\#2495](https://github.com/googleforgames/agones/issues/2495) | ||
- Support Agones on ARM systems [\#2216] (https://github.com/googleforgames/agones/issues/2216) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reopened this issue, since it was accidentally closed. This work is not yet complete, it's only been started.
We should remove this line from the release notes and Changelog (if the Changelog was run before I reopened the issue).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this was resolved, but it looks like the ARM issue (#2216) is still listed here and on the CHANGELOG as completed, when it's not. Maybe you removed a different one? (Apologies if I wasn't clear).
Co-authored-by: Mark Mandel <markmandel@google.com>
Build Succeeded 👏 Build Id: b1eeb335-6bdd-4c0a-aaad-271447a3cc8a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…nto release-v1.22.0-rc
Build Succeeded 👏 Build Id: 5eb69499-6f08-4c65-86a1-358cb71388ca The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new release documentation isn't showing up on https://1c68b24-dot-preview-dot-agones-images.appspot.com/site/blog/ because the filename doesn't end with ".md" so the web server isn't interpreting it as a markdown page to display. Please rename 1.22.0-rc to 1.22.0-rc.md.
- Add Allocation Endpoint GCP solution for multi-cluster allocation to Agones examples [\#2499](https://github.com/googleforgames/agones/pull/2499) ([pooneh-m](https://github.com/pooneh-m)) | ||
- Add a tool that can run variable allocation load scenarios [\#2493](https://github.com/googleforgames/agones/pull/2493) ([roberthbailey](https://github.com/roberthbailey)) | ||
- updates for next release [\#2482](https://github.com/googleforgames/agones/pull/2482) ([SaitejaTamma](https://github.com/SaitejaTamma)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back the line
Documentation: https://development.agones.dev/site/
Build Succeeded 👏 Build Id: c3a94d89-70a4-423f-8214-dbd619667d36 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 1c20f870-3ef6-457e-b5f2-31fa14237ad7 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: fc8c93f1-f38f-4895-a964-3677da1b9097 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
**Implemented enhancements:** | ||
|
||
- Add a multi-cluster allocation example solution to leverage GCP resources to connect to multiple Agones clusters [\#2495](https://github.com/googleforgames/agones/issues/2495) | ||
- Support Agones on ARM systems [\#2216] (https://github.com/googleforgames/agones/issues/2216) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line still needs to be removed from here.
Build Failed 😱 Build Id: f4695c7f-4b3c-4e47-bab5-e81700482dd1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
e2e flaked:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey, SaitejaTamma, steven-supersolid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 06788fcd-eda0-468c-b285-d86af2653b29 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…ebhook (#2528) * Release v1.22.0 rc (#2519) * release v1.22.0-rc * Re-generated Install.yaml * Changes on new release.md file * Update site/content/en/blog/releases/1.22.0-rc Co-authored-by: Mark Mandel <markmandel@google.com> * Changes * updated and renamed the md file * regenerated changelog file * changes for md and changelog files Co-authored-by: Mark Mandel <markmandel@google.com> * Fix annotations * Fix documentations * Add custom secret * Update documentations * minor Co-authored-by: SaitejaTamma <89424310+SaitejaTamma@users.noreply.github.com> Co-authored-by: Mark Mandel <markmandel@google.com>
…ebhook (#2528) * Release v1.22.0 rc (#2519) * release v1.22.0-rc * Re-generated Install.yaml * Changes on new release.md file * Update site/content/en/blog/releases/1.22.0-rc Co-authored-by: Mark Mandel <markmandel@google.com> * Changes * updated and renamed the md file * regenerated changelog file * changes for md and changelog files Co-authored-by: Mark Mandel <markmandel@google.com> * Fix annotations * Fix documentations * Add custom secret * Update documentations * minor Co-authored-by: SaitejaTamma <89424310+SaitejaTamma@users.noreply.github.com> Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/Kind Release
What this PR does / Why we need it:
v1.22.0-rc
Which issue(s) this PR fixes:
Closes #2518
Special notes for your reviewer: