Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fleetautoscaler e2e certs #2541

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Looks like they expired recently. Renewing them for 18 months.

Which issue(s) this PR fixes:

Unblocks CI

Special notes for your reviewer:

I thought about trying to generate the cert dynamically each time, but it seemed like more work than generating the new cert.

Looks like they expired recently. Renewing them for 18 months.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Apr 12, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9ae28cf9-64dc-4ad7-a4d2-8d2d9cf8775d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2541/head:pr_2541 && git checkout pr_2541
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-c56621f

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 6a126c7 into googleforgames:main Apr 12, 2022
@markmandel markmandel deleted the certs/update-tls-tests branch April 15, 2022 17:07
Thiryn pushed a commit to Thiryn/agones that referenced this pull request Apr 25, 2022
Looks like they expired recently. Renewing them for 18 months.
@SaitejaTamma SaitejaTamma added this to the 1.23.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants