Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some Info logging to Debug #2547

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Was cleaning up a single instance where an Info log should have been Debug, so decided to do a scan of the codebase, and found a few different places where we have logging that should be Debug as it's either (a) verbose or (b) not relevant for production systems.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N.A

Was cleaning up a single instance where an Info log should have been
Debug, so decided to do a scan of the codebase, and found a few
different places where we have logging that should be Debug as it's
either (a) verbose or (b) not relevant for production systems.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Apr 20, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 13ff1549-3c66-46a0-ad67-82129fdcf5fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

TestGameServerRestartBeforeReadyCrash - should really find a way to fix this flake.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 91e92651-a0ce-4049-9b3e-8200ee3f54e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2547/head:pr_2547 && git checkout pr_2547
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-7c45342

@markmandel markmandel merged commit c23d41a into googleforgames:main Apr 20, 2022
@markmandel markmandel deleted the cleanup/info-debug-logging branch April 20, 2022 22:27
Thiryn pushed a commit to Thiryn/agones that referenced this pull request Apr 25, 2022
Was cleaning up a single instance where an Info log should have been
Debug, so decided to do a scan of the codebase, and found a few
different places where we have logging that should be Debug as it's
either (a) verbose or (b) not relevant for production systems.
@SaitejaTamma SaitejaTamma added this to the 1.23.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants