-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rolling update test to support >1 inactive GameServerSets #2575
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivotimev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: e4d5149a-5206-4354-a082-ec6f306cc7ce To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 68fb617d-e684-4c83-9868-08f4a2fbdb32 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: c7841f91-5a94-45c9-bc3d-0f41fd18fef6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Just having a quick look at this - was this e2e test meant to fail? |
Gently bumping this - wanted to get more context on unit test? |
This has been sitting for a while now. I'm going to close it, but please feel free to revisit at a later date. |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This PR refactors the Rolling Update Deployment table tests to support >1 inactive game server sets.
It also adds a test that replicates Issue 2574: Presence of >2 GSS can cause a rolling update to become stuck until an allocation ends and highlights the issue.
Special notes for your reviewer:
The idea of this PR is to minimally reproduce Issue 2574.