Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rolling update test to support >1 inactive GameServerSets #2575

Closed

Conversation

ivotimev
Copy link

@ivotimev ivotimev commented May 11, 2022

What type of PR is this?
/kind bug

What this PR does / Why we need it:
This PR refactors the Rolling Update Deployment table tests to support >1 inactive game server sets.
It also adds a test that replicates Issue 2574: Presence of >2 GSS can cause a rolling update to become stuck until an allocation ends and highlights the issue.

Special notes for your reviewer:
The idea of this PR is to minimally reproduce Issue 2574.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivotimev
To complete the pull request process, please assign pooneh-m after the PR has been reviewed.
You can assign the PR to them by writing /assign @pooneh-m in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivotimev ivotimev changed the title Refactor rolling update test to support >2 GameServerSets with allocated replicas and expose bug Refactor rolling update test to support >1 inactive GameServerSets May 11, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e4d5149a-5206-4354-a082-ec6f306cc7ce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 68fb617d-e684-4c83-9868-08f4a2fbdb32

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2575/head:pr_2575 && git checkout pr_2575
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-81da719-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c7841f91-5a94-45c9-bc3d-0f41fd18fef6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2575/head:pr_2575 && git checkout pr_2575
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-c3ce7ee-amd64

@markmandel
Copy link
Member

Just having a quick look at this - was this e2e test meant to fail?

@markmandel
Copy link
Member

Gently bumping this - wanted to get more context on unit test?

@SaitejaTamma SaitejaTamma added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 14, 2022
@SaitejaTamma SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 22, 2022
@markmandel
Copy link
Member

This has been sitting for a while now. I'm going to close it, but please feel free to revisit at a later date.

@markmandel markmandel closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants