Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test fix: TestWorkQueueHealthCheck #260

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Flaky test fix: TestWorkQueueHealthCheck #260

merged 1 commit into from
Jun 13, 2018

Conversation

markmandel
Copy link
Member

I believe this should fix this flaky test

@markmandel
Flakey test fix: TestWorkQueueHealthCheck
3bc43e0 
I believe this shoud fix this flakey test
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 12, 2018
@markmandel markmandel added this to the 0.3.0 milestone Jun 12, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 54ba3e0e-ea13-4657-a360-9a82a2705d88

The following development artifacts have been built, and will exist for the next 30 days:

@markmandel
Copy link
Member Author

@enocom is this hacky, or genius, or both? 😄 (review if you have time)

@enocom enocom self-requested a review June 13, 2018 01:44
enocom
enocom approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing robust tests against concurrent code is hard. This looks like a more robust approach. 👍

@enocom enocom merged commit cf9b85f into googleforgames:master Jun 13, 2018
@markmandel markmandel deleted the cleanup/workerqueue-test-fix branch June 13, 2018 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @enocom