Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue template for Kubernetes Upgrades #2606

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Issue template for Kubernetes Upgrades #2606

merged 2 commits into from
Jun 2, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This came up on a community call, so I'm finally putting it together 😄

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label May 31, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d9f8ca16-0560-43f5-82f1-7bd16ea41b28

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

e2e stable, TestFleetRollingUpdate - flake

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dddff719-91e2-471a-ba35-5e8abce0c833

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2606/head:pr_2606 && git checkout pr_2606
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-6016d19-amd64

roberthbailey
roberthbailey reviewed Jun 1, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/kubernetes_update.md Outdated
- [ ] Kind
- [ ] Update client-go
- [ ] Update CRD API reference
- [ ] Update links to k8s documentation in site/assets/templates/crd-doc-config.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you surround the filename here in backticks (like you did on lines 21-22)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

.github/ISSUE_TEMPLATE/kubernetes_update.md Outdated
name: Upgrade Kubernetes Version
about: Issue for updating the Kubernetes version (usually decided in community meetings).
title: 'Update Kubernetes to {version}'
labels: kind/operations, kind/feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually mark these as kind/breaking since we our current upgrade strategy is pretty disruptive. However, I'm ok marking the issue as a feature and the PRs as breaking if that generates better release notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's a really good point. It should be breaking. I'll make that tweak.

@roberthbailey roberthbailey self-assigned this Jun 1, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 13120e16-5c24-4f70-bcd2-11eedb763632

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Issue template for Kubernetes Upgrades
68823a1 
This came up on a community call, so I'm finally putting it together 😄
@markmandel
Review updates.
c14aa1c
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 342e8a5b-7b21-47bf-9e56-385b0b9285d6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2473156b-a2b1-44f5-81cb-6f5f617e8315

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2606/head:pr_2606 && git checkout pr_2606
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-c14aa1c-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jun 2, 2022
@roberthbailey roberthbailey merged commit 2d5ec2e into googleforgames:main Jun 2, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the template/k8s_update branch June 6, 2022 21:18
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. lgtm size/M
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @SaitejaTamma