Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extra step to the kubernetes upgrade tasks. #2616

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it: Add an extra step to the k8s upgrade tasks so that we keep the image used for uninstall up to date. We had been using one that was very old (prior to #2615) and we should use one that is at the same version as the version of Kubernetes that we support to ensure maximum compatibility.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@roberthbailey roberthbailey added the kind/documentation Documentation for Agones label Jun 7, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0201d29e-f78f-4f2f-b25a-7c22eec62d76

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2616/head:pr_2616 && git checkout pr_2616
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-79c5670-amd64

@markmandel markmandel merged commit 6cf8a8e into googleforgames:main Jun 7, 2022
@markmandel markmandel added this to the 1.24.0 milestone Jun 7, 2022
@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants