-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added information about Agones running on Azure Kubernetes Service #269
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7b7c842
added information about Agones running on Azure Kubernetes Service
dgkanatsios 787e2f0
Merge branch 'master' into master
dgkanatsios 73f2a62
Merge branch 'master' into master
dgkanatsios 9e400f6
Merge branch 'master' into master
dgkanatsios File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For AKS, did you need to do anything for RBAC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! So, I can confirm that nothing else needs to be set for RBAC apart from the existing instructions/commands, just did a quick test by creating a cluster from scratch with RBAC enabled, installed Agones and quickstarting a game server, having a successful ACK. Apparently, the Agones controllers are working just fine.
Anything else I should check to make sure Agones RBAC stuff is working as intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dgkanatsios ,
if you created the gameserver in the default namespace and the controller lived in the agones-system you have tested RBAC, if RBAC was active it wouldn't work. Assuming pods of the gameserver was 2/2 active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I think @markmandel was wondering if the kubectl config fetched by
az aks get-credentials
get a cluster-admin role by default, I guess the answer is yes again since you were able to install agones, is this correct ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I vaguely remember some conversation about whether you needed the AKS equivalent of
Did you end up needing to do that? If not, we should probably also make that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your comments @Kuqd and @markmandel! To answer your questions
dgkanatsios@digkanat:~$ k get po --all-namespaces NAMESPACE NAME READY STATUS RESTARTS AGE agones-system agones-controller-cfccbcc6b-v9xr2 1/1 Running 0 15h default simple-udp-msmr9 2/2 Running 0 15h kube-system azureproxy-899885bfb-5rsql 1/1 Running 2 15h kube-system heapster-56c6f9566f-pkbxw 2/2 Running 0 15h kube-system kube-dns-v20-7c556f89c5-75qzb 3/3 Running 0 15h kube-system kube-dns-v20-7c556f89c5-msfbc 3/3 Running 0 15h kube-system kube-proxy-rsjpn 1/1 Running 0 15h kube-system kube-svc-redirect-gtghx 1/1 Running 0 15h kube-system kubernetes-dashboard-5ffc5c5558-tdkwh 1/1 Running 4 15h kube-system tunnelfront-856cdb8bb7-khs86 1/1 Running 0 15h
az aks get-credentials
fetches admin credentials. You end up with a kubeconfig with that has an embedded cert with an identity of system:masters, which has a cluster-admin ClusterRoleBinding. Agones itself as well as test game server are installed with kubectl using these credentials. Moreover, all default cluster roles are there, including cluster-admin.Some commands output as well:
thanks!