Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear metric labels on Fleet/Autoscaler delete #2701

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Clear metric labels on Fleet/Autoscaler delete #2701

merged 5 commits into from
Sep 1, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This introduces a new feature flag ResetMetricsOnDelete which when enabled, resets the appropriate metric views and revuilds them, thereby dropping labels for Fleets and/or Fleet Autoscalers when they get deleted.

Which issue(s) this PR fixes:

Closes #2478

Special notes for your reviewer:

@markmandel markmandel added kind/bug These are bugs. area/operations Installation, updating, metrics etc labels Aug 5, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bffb59b1-8a77-4313-9681-0f25c49b48df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-14d30fb-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ca65ce99-da33-47f5-a5fa-a12e5038c97e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Caught by TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true in e2e-stable again.

me="2022-08-08 20:43:40.271" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0f7sz9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
panic: Fail in goroutine after TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true has completed

goroutine 1792 [running]:
testing.(*common).Fail(0xc000901a00)
	/usr/local/go/src/testing/testing.go:710 +0x1b4
testing.(*common).Errorf(0xc00078d0c0, {0x216a601, 0x3}, {0xc00078d0b0, 0x1, 0x1})
	/usr/local/go/src/testing/testing.go:818 +0x85
github.com/stretchr/testify/assert.Fail({0x2410a80, 0xc000901a00}, {0xc000995620, 0x5f}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/assert/assertions.go:262 +0x43d
github.com/stretchr/testify/assert.NoError({0x2410a80, 0xc000901a00}, {0x240ff80, 0xc00074e640}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/assert/assertions.go:1332 +0x125
github.com/stretchr/testify/require.NoError({0x2429f28, 0xc000901a00}, {0x240ff80, 0xc00074e640}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/require/require.go:1231 +0xa5
agones.dev/agones/test/e2e/framework.(*Framework).CycleAllocations.func1.1(0xc0003b2b40)
	/go/src/agones.dev/agones/test/e2e/framework/framework.go:297 +0x1b4
created by agones.dev/agones/test/e2e/framework.(*Framework).CycleAllocations.func1
	/go/src/agones.dev/agones/test/e2e/framework/framework.go:294 +0x7e8
FAIL	agones.dev/agones/test/e2e	321.445s
FAIL
make[1]: *** [Makefile:306: test-e2e-integration] Error 1
make[1]: Leaving directory '/workspace/build'
make: *** [Makefile:297: test-e2e] Error 2

https://console.cloud.google.com/cloud-build/builds/ca65ce99-da33-47f5-a5fa-a12e5038c97e?project=258182270954

@markmandel
Copy link
Member Author

Conflicts have been fixed!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7c6f9d55-98b8-4029-b283-4a55590d363a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-b611113-amd64

@markmandel
Copy link
Member Author

Gentle bump on review @roberthbailey 😄

roberthbailey
roberthbailey reviewed Aug 18, 2022
View reviewed changes
pkg/metrics/controller.go Show resolved Hide resolved
pkg/metrics/controller.go Show resolved Hide resolved
pkg/metrics/controller_metrics.go Show resolved Hide resolved
site/content/en/docs/Guides/metrics.md Show resolved Hide resolved
@markmandel
Clear metric labels on Fleet/Autoscaler delete
9bca313 
This introduces a new feature flag `ResetMetricsOnDelete` which when
enabled, resets the appropriate metric views and revuilds them, thereby
dropping labels for Fleets and/or Fleet Autoscalers when they get
deleted.

Closes googleforgames#2478
@markmandel
Review updates.
54f85eb
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 36731ecb-ece8-4b3b-b9bf-e130402e29b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-54f85eb-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9d2b724f-8859-4892-b5f9-ea77fd345bb6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-8782d24-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: adc788a7-a754-4da6-ab9a-1a54372d7778

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-3c63496-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Sep 1, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Sep 1, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 175dce8a-1178-4347-b9eb-865346d1ad80

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-580f8f4-amd64

@markmandel markmandel merged commit 84c7818 into googleforgames:main Sep 1, 2022
@markmandel markmandel deleted the cleanup/delete-fleet-metrics branch September 1, 2022 23:40
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/bug These are bugs. size/L
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

Fleet specific prometheus metrics should stop being exported when the fleet is deleted
4 participants
@markmandel @agones-bot @roberthbailey @SaitejaTamma