Implemented PodDisruptionBudget on relevant deployments #2740

valentintorikian · 2022-09-14T03:36:58Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Added (optional) PodDisruptionBudget creation for the ping and allocator deployment. Disabled by default.
Will allow for better management of voluntary disruptions.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

agones-bot · 2022-09-14T04:03:38Z

Build Succeeded 👏

Build Id: 509435e5-e37b-4c21-a44b-953204dc26b2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.26.0-5725210-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.26.0-5725210-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.26.0-5725210-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.26.0-5725210-amd64
Linux C++ SDK (build): agonessdk-1.26.0-5725210-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.26.0-5725210-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5725210-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-5725210-amd64

roberthbailey · 2022-09-14T04:39:33Z

Thanks for the PR! I will take a look at it once the in-progress release is finalized (also, you will probably have to rebase and deal with conflicts in the documentation changes at that point).

agones-bot · 2022-09-18T17:03:44Z

Build Succeeded 👏

Build Id: 9f9325d1-9094-497f-9c40-760d1d8edb4d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-8ca4d02-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-8ca4d02-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-8ca4d02-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-8ca4d02-amd64
Linux C++ SDK (build): agonessdk-1.27.0-8ca4d02-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-8ca4d02-amd64.zip

A preview of the website (the last 30 builds are retained):

https://8ca4d02-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-8ca4d02-amd64

agones-bot · 2022-09-18T17:19:39Z

Build Succeeded 👏

Build Id: 9de7fb60-ffca-41e9-927b-85b51581ea61

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-454ade0-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-454ade0-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-454ade0-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-454ade0-amd64
Linux C++ SDK (build): agonessdk-1.27.0-454ade0-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-454ade0-amd64.zip

A preview of the website (the last 30 builds are retained):

https://454ade0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-454ade0-amd64

roberthbailey · 2022-09-19T05:45:35Z

@valentintorikian - As expected, you now need to rebase your documentation changes.

valentintorikian · 2022-09-19T14:14:30Z

@roberthbailey rebased

agones-bot · 2022-09-19T14:41:54Z

Build Succeeded 👏

Build Id: 41e283be-ac80-41ea-9543-2c6456c75670

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-807468d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-807468d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-807468d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-807468d-amd64
Linux C++ SDK (build): agonessdk-1.27.0-807468d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-807468d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://807468d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-807468d-amd64

markmandel · 2022-09-29T20:10:10Z

@roberthbailey just gently bumping if this is good to go? Looks like you were reviewing 😃

roberthbailey · 2022-09-30T06:17:28Z

install/helm/agones/templates/ping.yaml

+  name: agones-ping-pdb
+spec:
+  minAvailable: {{ .Values.agones.ping.pdb.minAvailable }}
+  maxUnavailable: {{ .Values.agones.ping.pdb.maxUnavailable }}


According to https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget the above two fields are mutually exclusive (e.g. you can only set one or the other).

It isn't clear to me what happens if the spec looks like:

spec: minAvailable: 2 maxUnavailable:

which is what will be produced if the boolean to enable this is toggled to true. Is that spec accepted by k8s or rejected?

Does the template here need to be more complicated so that we only set a single value?

I was curious, so I tested this. It works fine, and sends the JSON you might expect: "spec":{"maxUnavailable":null,"minAvailable":0, [...]}.

Thanks @zmerlynn for checking that out. Do you think this is ok to submit as-is then?

I think it should still be documented, but we could also merge and come back to that later.

roberthbailey · 2022-09-30T06:21:51Z

site/content/en/docs/Installation/Install Agones/helm.md

+| Parameter                             | Description                                                                                                                                                                                | Default |
+|---------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
+| `agones.allocator.pdb.enabled`        | Set to `true` to enable the creation of a [PodDisruptionBudget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for the allocator deployment                              | `false` |
+| `agones.allocator.pdb.minAvailable`   | Description of the number of pods from that set that must still be available after the eviction, even in the absence of the evicted pod. Can be either an absolute number or a percentage. | `1`     |


In each of the lines for minAvailable and maxUnavailable can you note that the two fields are mutually exclusive? Following the link to PDBs you can find this but it would be nice to highlight it here as well.

agones-bot · 2022-09-30T06:49:22Z

Build Succeeded 👏

Build Id: e10468d0-5167-4688-91cc-6c0bade55422

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-f1df1bd-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-f1df1bd-amd64
Linux C++ SDK (build): agonessdk-1.27.0-f1df1bd-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-f1df1bd-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

markmandel · 2022-10-10T18:48:56Z

Just a gentle reminder that our Release Candidate comes out next week, so if you would like this in our next release, Tuesday next week is the deadline.

agones-bot · 2022-10-14T21:46:15Z

Build Failed 😱

Build Id: 3dd445f7-851d-442a-84d6-f33b068dc276

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-10-14T23:13:55Z

Build Succeeded 👏

Build Id: 4ce81b70-be04-441a-8f14-6eee240e15b8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-f1df1bd-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-f1df1bd-amd64
Linux C++ SDK (build): agonessdk-1.27.0-f1df1bd-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-f1df1bd-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

agones-bot · 2022-10-15T00:20:44Z

Build Succeeded 👏

Build Id: 68990e16-e340-41db-85fc-3d7da364742b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-f1df1bd-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-f1df1bd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-f1df1bd-amd64
Linux C++ SDK (build): agonessdk-1.27.0-f1df1bd-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-f1df1bd-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

- added a pdb on the ping deployment - added a pdb on the allocator deployment - default to no creation of pdb, opt-in install

agones-bot · 2022-10-22T05:34:09Z

Build Succeeded 👏

Build Id: 47000304-7854-4a68-9d75-626b078bce56

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.27.0-0894d7b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.27.0-0894d7b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.27.0-0894d7b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.27.0-0894d7b-amd64
Linux C++ SDK (build): agonessdk-1.27.0-0894d7b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.27.0-0894d7b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0894d7b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-0894d7b-amd64

agones-bot · 2022-11-09T06:00:52Z

Build Succeeded 👏

Build Id: e40326e6-0fc9-4156-89d0-be92c08192a1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-fd19f47-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-fd19f47-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-fd19f47-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-fd19f47-amd64
Linux C++ SDK (build): agonessdk-1.28.0-fd19f47-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-fd19f47-amd64.zip

A preview of the website (the last 30 builds are retained):

https://fd19f47-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-fd19f47-amd64

zmerlynn

@roberthbailey I'm happy to fix up the documentation on mutual-exclusivity after this goes in.

zmerlynn · 2022-11-14T17:47:54Z

@roberthbailey I'm happy to fix up the documentation on mutual-exclusivity after this goes in.

It looks like we could even use an approach like https://stackoverflow.com/questions/53508229/helm-chart-with-dependent-values to just ensure it.

google-oss-prow · 2022-11-18T09:58:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, valentintorikian, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2022-11-18T10:34:58Z

Build Succeeded 👏

Build Id: b062ad7a-4082-4a31-af8c-1caf1950a613

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-12f90ad-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-12f90ad-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-12f90ad-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-12f90ad-amd64
Linux C++ SDK (build): agonessdk-1.28.0-12f90ad-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-12f90ad-amd64.zip

A preview of the website (the last 30 builds are retained):

https://12f90ad-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-12f90ad-amd64

google-oss-prow bot requested review from EricFortin and roberthbailey September 14, 2022 03:37

google-oss-prow bot added the size/M label Sep 14, 2022

SaitejaTamma added the kind/feature New features for Agones label Sep 14, 2022

valentintorikian force-pushed the implements-pdb branch 2 times, most recently from 8ca4d02 to 454ade0 Compare September 18, 2022 16:38

valentintorikian force-pushed the implements-pdb branch from 454ade0 to 807468d Compare September 19, 2022 14:13

roberthbailey reviewed Sep 30, 2022

View reviewed changes

mangalpalli added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Oct 18, 2022

Implemented PodDisruptionBudget on relevant deployments

0894d7b

- added a pdb on the ping deployment - added a pdb on the allocator deployment - default to no creation of pdb, opt-in install

valentintorikian force-pushed the implements-pdb branch from f1df1bd to 0894d7b Compare October 22, 2022 05:07

mangalpalli removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Oct 26, 2022

Merge branch 'main' into implements-pdb

fd19f47

zmerlynn self-assigned this Nov 14, 2022

zmerlynn approved these changes Nov 14, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Nov 14, 2022

Merge branch 'main' into implements-pdb

12f90ad

google-oss-prow bot removed the lgtm label Nov 18, 2022

roberthbailey approved these changes Nov 18, 2022

View reviewed changes

google-oss-prow bot assigned roberthbailey Nov 18, 2022

google-oss-prow bot added the lgtm label Nov 18, 2022

google-oss-prow bot added the approved label Nov 18, 2022

roberthbailey merged commit 0a8d878 into googleforgames:main Nov 18, 2022

chiayi mentioned this pull request Nov 28, 2022

Validation and documentation for PodDiscriptionBudget change #2829

Merged

mangalpalli added this to the 1.28.0 milestone Nov 29, 2022

zmerlynn mentioned this pull request Nov 29, 2022

Request for zmerlynn to become Approver #2833

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented PodDisruptionBudget on relevant deployments #2740

Implemented PodDisruptionBudget on relevant deployments #2740

valentintorikian commented Sep 14, 2022

agones-bot commented Sep 14, 2022

roberthbailey commented Sep 14, 2022

agones-bot commented Sep 18, 2022

agones-bot commented Sep 18, 2022

roberthbailey commented Sep 19, 2022

valentintorikian commented Sep 19, 2022

agones-bot commented Sep 19, 2022

markmandel commented Sep 29, 2022

roberthbailey Sep 30, 2022

zmerlynn Nov 7, 2022

roberthbailey Nov 9, 2022

zmerlynn Nov 9, 2022

roberthbailey Sep 30, 2022

agones-bot commented Sep 30, 2022

markmandel commented Oct 10, 2022

agones-bot commented Oct 14, 2022

agones-bot commented Oct 14, 2022

agones-bot commented Oct 15, 2022

agones-bot commented Oct 22, 2022

agones-bot commented Nov 9, 2022

zmerlynn left a comment

zmerlynn commented Nov 14, 2022

google-oss-prow bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

Implemented PodDisruptionBudget on relevant deployments #2740

Implemented PodDisruptionBudget on relevant deployments #2740

Conversation

valentintorikian commented Sep 14, 2022

agones-bot commented Sep 14, 2022

roberthbailey commented Sep 14, 2022

agones-bot commented Sep 18, 2022

agones-bot commented Sep 18, 2022

roberthbailey commented Sep 19, 2022

valentintorikian commented Sep 19, 2022

agones-bot commented Sep 19, 2022

markmandel commented Sep 29, 2022

roberthbailey Sep 30, 2022

Choose a reason for hiding this comment

zmerlynn Nov 7, 2022

Choose a reason for hiding this comment

roberthbailey Nov 9, 2022

Choose a reason for hiding this comment

zmerlynn Nov 9, 2022

Choose a reason for hiding this comment

roberthbailey Sep 30, 2022

Choose a reason for hiding this comment

agones-bot commented Sep 30, 2022

markmandel commented Oct 10, 2022

agones-bot commented Oct 14, 2022

agones-bot commented Oct 14, 2022

agones-bot commented Oct 15, 2022

agones-bot commented Oct 22, 2022

agones-bot commented Nov 9, 2022

zmerlynn left a comment

Choose a reason for hiding this comment

zmerlynn commented Nov 14, 2022

google-oss-prow bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022