Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Kubernetes upgrade instructions to include instructions for upgrading gRPC #2755

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Follow up to #2725 and #2727 so that the next time we do a Kubernetes upgrade we remember how to upgrade gRPC across the project.

I also snuck in a documentation fix to include make gen-all-sdk-grpc in the build documentation since it was previously missing.

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 29, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 06fabc64-a3ce-4309-a0c7-487feea8db20

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2755/head:pr_2755 && git checkout pr_2755
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-6dce7d5-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Sep 29, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 29b130f into googleforgames:main Sep 29, 2022
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants