Release Automation: Generate version of website to push #2808

mangalpalli · 2022-11-11T17:37:44Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

kind feature

/kind hotfix

What this PR does / Why we need it:
We need to have a make target to push a new version of the website during a release to capture a snapshot before we make changes. But we didn't have one that created the proper version string for the release and required to change the version string manually.

Which issue(s) this PR fixes:
We created a make target that can generate and format the proper version string for the release.

Closes #2457
Special notes for your reviewer:

agones-bot · 2022-11-11T17:43:57Z

Build Failed 😱

Build Id: 25bea67f-3990-4b5b-966a-3d0ea2e4790b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-11-11T18:33:12Z

Build Succeeded 👏

Build Id: 42a96d16-579a-45d1-8dac-44469f28c3ae

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-0bae03c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-0bae03c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-0bae03c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-0bae03c-amd64
Linux C++ SDK (build): agonessdk-1.28.0-0bae03c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-0bae03c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0bae03c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-0bae03c-amd64

agones-bot · 2022-11-11T18:40:05Z

Build Succeeded 👏

Build Id: 104050c4-d4f8-4150-8b5b-c4f63aceaec8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-4c11eda-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-4c11eda-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-4c11eda-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-4c11eda-amd64
Linux C++ SDK (build): agonessdk-1.28.0-4c11eda-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-4c11eda-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4c11eda-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-4c11eda-amd64

build/scripts/previousversion/main.go

markmandel · 2022-11-11T22:23:12Z

build/scripts/previousversion/main.go

+	baseVersion := flag.String("version", "", "the base version to be taken in as input for release")
+	flag.Parse()
+	v, _ := semver.Parse(*baseVersion)
+	releaseVersion := fmt.Sprintf("%d.%d.%d", v.Major, v.Minor-1, v.Patch)


ooooh! So we missed a small part of the requirements in the ticket:

(replace . with -)

But we can do this here! Use - rather than ., and we are good to go!

Updated it.

markmandel · 2022-11-11T23:55:49Z

With the notes above - you should be able to deploy a 1-27-0 service on App Engine - which would be neat!

agones-bot · 2022-11-14T16:43:41Z

Build Failed 😱

Build Id: bd7dcbe7-b1b2-42e7-94dd-33270eb29c1c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-11-14T17:00:36Z

Build Succeeded 👏

Build Id: 59f039ff-b9cf-48fc-867a-921887e6e065

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-78d0dc9-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-78d0dc9-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-78d0dc9-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-78d0dc9-amd64
Linux C++ SDK (build): agonessdk-1.28.0-78d0dc9-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-78d0dc9-amd64.zip

A preview of the website (the last 30 builds are retained):

https://78d0dc9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-78d0dc9-amd64

markmandel · 2022-11-17T18:59:42Z

This looks good! Only thing extra to add, would be to update https://github.com/googleforgames/agones/blob/main/docs/governance/templates/release_issue.md to use this process instead!

mangalpalli · 2022-11-17T19:09:34Z

This looks good! Only thing extra to add, would be to update https://github.com/googleforgames/agones/blob/main/docs/governance/templates/release_issue.md to use this process instead!

I will update it.

agones-bot · 2022-11-18T17:36:59Z

Build Failed 😱

Build Id: 6c1471bc-8a95-4720-8d8e-cc9efc759ef6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-11-18T17:54:59Z

Build Failed 😱

Build Id: 64aea425-271b-4fea-9603-3a07c1c53338

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-11-18T18:12:14Z

Build Succeeded 👏

Build Id: e1d9d635-5483-4ce4-b737-f1decd57e60f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-ffda96a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-ffda96a-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-ffda96a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-ffda96a-amd64
Linux C++ SDK (build): agonessdk-1.28.0-ffda96a-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-ffda96a-amd64.zip

A preview of the website (the last 30 builds are retained):

https://ffda96a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-ffda96a-amd64

agones-bot · 2022-11-18T18:20:17Z

Build Succeeded 👏

Build Id: 86127a99-4cec-4deb-b421-5ad9e1c70606

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-cc81e4e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-cc81e4e-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-cc81e4e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-cc81e4e-amd64
Linux C++ SDK (build): agonessdk-1.28.0-cc81e4e-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-cc81e4e-amd64.zip

A preview of the website (the last 30 builds are retained):

https://cc81e4e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-cc81e4e-amd64

markmandel

Looks good! just missing a licence, and it's good to go 👍🏻

markmandel · 2022-11-18T20:30:53Z

build/scripts/previousversion/go.mod

@@ -0,0 +1,5 @@
+module github.com/agones/agones/build/scripts/previousversion
+
+go 1.19


Looks good! I think this is cleaner, what do you think?

build/scripts/previousversion/main.go

agones-bot · 2022-12-01T16:52:14Z

Build Failed 😱

Build Id: 92440934-a724-4289-aab7-a5527a223a2c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-12-01T17:11:13Z

Build Succeeded 👏

Build Id: db1d8292-ceff-402b-8c82-62dd86a1cef6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-78fc6a6-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-78fc6a6-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-78fc6a6-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-78fc6a6-amd64
Linux C++ SDK (build): agonessdk-1.28.0-78fc6a6-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-78fc6a6-amd64.zip

A preview of the website (the last 30 builds are retained):

https://78fc6a6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-78fc6a6-amd64

markmandel

This looks good!

If you feel confident, we can merge this now, so it's ready for you to use during the 1.28.0 stable release. (will need to move it out of draft).

Also, thanks for squashing all the commits! 😃

agones-bot · 2022-12-01T18:30:00Z

Build Succeeded 👏

Build Id: 1e893758-9cfe-4f5b-9559-c972e35436be

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-c8ef1cc-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-c8ef1cc-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-c8ef1cc-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-c8ef1cc-amd64
Linux C++ SDK (build): agonessdk-1.28.0-c8ef1cc-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-c8ef1cc-amd64.zip

A preview of the website (the last 30 builds are retained):

https://c8ef1cc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-c8ef1cc-amd64

agones-bot · 2022-12-01T20:16:03Z

Build Succeeded 👏

Build Id: 03f05599-bb49-4a52-a894-15647087cc1b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.28.0-02eef3f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.28.0-02eef3f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.28.0-02eef3f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.28.0-02eef3f-amd64
Linux C++ SDK (build): agonessdk-1.28.0-02eef3f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.28.0-02eef3f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://02eef3f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-02eef3f-amd64

mangalpalli · 2022-12-05T16:10:22Z

This looks good!

If you feel confident, we can merge this now, so it's ready for you to use during the 1.28.0 stable release. (will need to move it out of draft).

Also, thanks for squashing all the commits! 😃

Yes, I feel confident. Was just thinking of taking it together in the next RC and release together. And may be merge it after tomorrow's release. What's your take?

markmandel · 2022-12-05T18:34:12Z

Okay - let's get stable out, and then we can merge it after that release is done 👍🏻

@igooch you might also find this interesting, since you are also looking at #2279

Added GOFLAGS argument and Apache header license Fixes for version data. initial commit for automating version testing version changes testing version changes testing version changes testing version changes issue-2457 changes issue-2457 release version automation automate version Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker lint error fixed review changes Resolved Merge conflicts updated go mod file Added GOFLAGS argument and Apache header license Added GOFLAGS argument and Apache header license Added GOFLAGS argument and Apache header license Added GOFLAGS argument and Apache header license Fixes for version data. testing version changes testing version changes testing version changes testing version changes issue-2457 changes issue-2457 release version automation automate version Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Testing automation in docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker Debug automation using docker lint error fixed review changes Resolved Merge conflicts updated go mod file Added GOFLAGS argument and Apache header license Added GOFLAGS argument and Apache header license initial commit for automating version

agones-bot · 2022-12-09T18:24:32Z

Build Failed 😱

Build Id: 50f43740-426e-40f8-9a6a-5fe5495679ff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-12-09T18:53:05Z

Build Failed 😱

Build Id: 6699c4bf-5315-4b8d-9a4c-c020908069f7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-12-09T19:22:19Z

Build Succeeded 👏

Build Id: 2247c6fa-6c26-4126-aa16-769d8a53aa27

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-a1dcb39-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-a1dcb39-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-a1dcb39-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-a1dcb39-amd64
Linux C++ SDK (build): agonessdk-1.29.0-a1dcb39-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-a1dcb39-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a1dcb39-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2808/head:pr_2808 && git checkout pr_2808
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-a1dcb39-amd64

markmandel

Approved.

@mangalpalli can you move this out of draft, and we can merge it in 👍🏻

google-oss-prow · 2022-12-09T19:37:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangalpalli, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…es#2808)

mangalpalli added the kind/feature New features for Agones label Nov 11, 2022

mangalpalli added this to the 1.28.0 milestone Nov 11, 2022

mangalpalli self-assigned this Nov 11, 2022

google-oss-prow bot added the do-not-merge/work-in-progress label Nov 11, 2022

google-oss-prow bot requested review from markmandel and roberthbailey November 11, 2022 17:37

google-oss-prow bot added the size/XXL label Nov 11, 2022

mangalpalli force-pushed the issue-2457 branch from 4c11eda to 0bae03c Compare November 11, 2022 17:57

markmandel reviewed Nov 11, 2022

View reviewed changes

mangalpalli force-pushed the issue-2457 branch from 7cc7ff0 to 78d0dc9 Compare November 14, 2022 16:24

mangalpalli force-pushed the issue-2457 branch 2 times, most recently from ffda96a to d200862 Compare November 18, 2022 17:32

google-oss-prow bot added size/M and removed size/XXL labels Nov 18, 2022

mangalpalli force-pushed the issue-2457 branch from cc81e4e to f990245 Compare November 18, 2022 17:42

markmandel reviewed Nov 18, 2022

View reviewed changes

mangalpalli force-pushed the issue-2457 branch 2 times, most recently from 929592e to 5433101 Compare November 21, 2022 19:10

markmandel approved these changes Dec 1, 2022

View reviewed changes

google-oss-prow bot assigned markmandel Dec 1, 2022

google-oss-prow bot added lgtm approved labels Dec 1, 2022

google-oss-prow bot removed the lgtm label Dec 1, 2022

mangalpalli removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 7, 2022

mangalpalli force-pushed the issue-2457 branch from 02eef3f to e026b82 Compare December 9, 2022 18:11

mangalpalli force-pushed the issue-2457 branch from e026b82 to 03c17ef Compare December 9, 2022 18:20

Merge branch 'main' into issue-2457

6acbc58

updated go.mod

a1dcb39

markmandel approved these changes Dec 9, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Dec 9, 2022

mangalpalli marked this pull request as ready for review December 9, 2022 19:46

google-oss-prow bot removed the do-not-merge/work-in-progress label Dec 9, 2022

google-oss-prow bot requested review from cyriltovena and EricFortin December 9, 2022 19:46

markmandel merged commit 8a1e83f into googleforgames:main Dec 9, 2022

markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Dec 9, 2022

chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022

Release Automation: Generate version of website to push (googleforgam…

1473d31

…es#2808)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release Automation: Generate version of website to push #2808

Release Automation: Generate version of website to push #2808

mangalpalli commented Nov 11, 2022

agones-bot commented Nov 11, 2022

agones-bot commented Nov 11, 2022

agones-bot commented Nov 11, 2022

markmandel Nov 11, 2022

mangalpalli Nov 14, 2022

markmandel commented Nov 11, 2022

agones-bot commented Nov 14, 2022

agones-bot commented Nov 14, 2022

markmandel commented Nov 17, 2022

mangalpalli commented Nov 17, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

markmandel left a comment

markmandel Nov 18, 2022

agones-bot commented Dec 1, 2022

agones-bot commented Dec 1, 2022

markmandel left a comment

agones-bot commented Dec 1, 2022

agones-bot commented Dec 1, 2022

mangalpalli commented Dec 5, 2022

markmandel commented Dec 5, 2022

agones-bot commented Dec 9, 2022

agones-bot commented Dec 9, 2022

agones-bot commented Dec 9, 2022

markmandel left a comment

google-oss-prow bot commented Dec 9, 2022

		@@ -0,0 +1,5 @@
		module github.com/agones/agones/build/scripts/previousversion

		go 1.19

Release Automation: Generate version of website to push #2808

Release Automation: Generate version of website to push #2808

Conversation

mangalpalli commented Nov 11, 2022

agones-bot commented Nov 11, 2022

agones-bot commented Nov 11, 2022

agones-bot commented Nov 11, 2022

markmandel Nov 11, 2022

Choose a reason for hiding this comment

mangalpalli Nov 14, 2022

Choose a reason for hiding this comment

markmandel commented Nov 11, 2022

agones-bot commented Nov 14, 2022

agones-bot commented Nov 14, 2022

markmandel commented Nov 17, 2022

mangalpalli commented Nov 17, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

agones-bot commented Nov 18, 2022

markmandel left a comment

Choose a reason for hiding this comment

markmandel Nov 18, 2022

Choose a reason for hiding this comment

agones-bot commented Dec 1, 2022

agones-bot commented Dec 1, 2022

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Dec 1, 2022

agones-bot commented Dec 1, 2022

mangalpalli commented Dec 5, 2022

markmandel commented Dec 5, 2022

agones-bot commented Dec 9, 2022

agones-bot commented Dec 9, 2022

agones-bot commented Dec 9, 2022

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Dec 9, 2022