Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace. #2839

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

roberthbailey
Copy link
Member

This allows the command can be copy/pasted.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
In the past two days I've copied this command a few times and gotten the error unrecognized arguments: followed by command not found: --enable-image-streaming. It took me a few minutes to realize it's because there is an extra space, which means the backslash isn't escaping the newline which turns this into two commands (neither of which works).

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6b45549-83b0-4852-aeac-a02070d38fb5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2839/head:pr_2839 && git checkout pr_2839
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-d555796-amd64

@gongmax
Copy link
Collaborator

gongmax commented Dec 2, 2022

Maybe we can add some Markdown linter so this kind of issue can be captured automatically in future.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This allows the command can be copy/pasted.
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e207b1b8-49f7-4503-acd5-3240cb40c32f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9e42e7c3-b8a5-436e-aa64-6f4f35d89765

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eb52813e-8cd3-435e-915b-ca515fbe3af9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2839/head:pr_2839 && git checkout pr_2839
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-eb04525-amd64

@zmerlynn zmerlynn merged commit 94092f9 into googleforgames:main Dec 2, 2022
@mangalpalli mangalpalli added this to the 1.28.0 milestone Dec 6, 2022
chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022
This allows the command can be copy/pasted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants