Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewFilteredSharedInformerFactory use NewSharedInformerFactoryWithOptions instead #2871

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

aimuz
Copy link
Collaborator

@aimuz aimuz commented Dec 15, 2022

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

// NewFilteredSharedInformerFactory constructs a new instance of sharedInformerFactory.
// Listers obtained via this SharedInformerFactory will be subject to the same filters
// as specified here.
// Deprecated: Please use NewSharedInformerFactoryWithOptions instead

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 01178717-df40-4ba6-8959-51645bcaf89c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn self-assigned this Dec 15, 2022
@zmerlynn
Copy link
Collaborator

This LGTM, but I'm going to wait on your other PR to merge.

@google-oss-prow google-oss-prow bot added the lgtm label Dec 15, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aimuz, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign pooneh-m for approval by writing /assign @pooneh-m in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ons instead

Signed-off-by: aimuz <mr.imuz@gmail.com>
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@zmerlynn zmerlynn enabled auto-merge (squash) December 15, 2022 17:46
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 32fe2a4b-977c-4ab7-bc32-ae83e55dd03e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2871/head:pr_2871 && git checkout pr_2871
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-ac794a5-amd64

@zmerlynn zmerlynn merged commit 4912d96 into googleforgames:main Dec 15, 2022
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants