Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates allocation load testing documentation #2883

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 28, 2022

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Clean up of load test documentation makes instructions on how to run the tests clearer.

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a8f05eb6-0d6b-467c-9f4e-68bc4aaef4da

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-40a4739-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: df00af23-8ada-4ef7-83e9-0f5cfddde213

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-d27e5e9-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f5a41dab-7aab-4c86-b6df-f40273858d2a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c873f8b5-9aad-4d93-942e-20f7f63ac037

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-91c9723-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b643532a-2bc6-4761-9dd7-c6acb746ad8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Looks like a flaky test:

--- FAIL: TestGameServerRestartBeforeReadyCrash (211.03s)
    gameserver_test.go:406: 
        	Error Trace:	gameserver_test.go:406
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestGameServerRestartBeforeReadyCrash

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c871c0ab-0079-48d9-a2e9-5428ffd9f1bf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-8dc9bdd-amd64

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the grammar comments are on text that was pre-existing, but since you moved around it seems like a good time to fix it.

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
test/load/allocation/README.md Outdated Show resolved Hide resolved
test/load/allocation/README.md Outdated Show resolved Hide resolved
test/load/allocation/README.md Outdated Show resolved Hide resolved
test/load/allocation/README.md Outdated Show resolved Hide resolved
test/load/allocation/README.md Outdated Show resolved Hide resolved
test/load/allocation/autoscaler.yaml Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 29d51a96-53ca-4dc0-abd5-f50ba6f08f73

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-013665b-amd64

minReplicas: 10000
maxReplicas: 20000
```
We used the sample [fleet configuration](./scenario-fleet.yaml and [fleet autoscaler configuration](./autoscaler.yaml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a closing ) for the first yaml file.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 674c3aee-da7c-4cbc-966b-a721ed8de5ed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-759f579-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 23235b83-3550-4a4f-a575-76540b4a4287

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Test flake in e2e-feature-gates:

--- FAIL: TestUnhealthyGameServersWithoutFreePorts (304.66s)
    gameserver_test.go:266: 
        	Error Trace:	gameserver_test.go:266
        	Error:      	Received unexpected error:
        	            	waiting for {game-server [{udp-port Static <nil> 7654 4812 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{game-server us-docker.pkg.dev/agones-images/examples/simple-game-server:0.14 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil}} <nil>} GameServer instance readiness timed out (): waiting for GameServer to be Ready 1672906077/game-serverrvnxt: timed out waiting for the condition
        	Test:       	TestUnhealthyGameServersWithoutFreePorts
FAIL

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f51e0f7c-6fcf-49be-bcf6-a8455942ee90

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2883/head:pr_2883 && git checkout pr_2883
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-f1682eb-amd64

@roberthbailey roberthbailey merged commit 73da855 into googleforgames:main Jan 5, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 17, 2023
@igooch igooch deleted the test-documentation branch January 26, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants