Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add --cloud-product flag, add SkipOnCloudProduct #2886

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Jan 6, 2023

  • Adds a simple --cloud-product flag to the e2e with no enforcement of validity.

  • Adds a SkipOnCloudProduct convenience function, and 2 callers.

Towards #2777

* Adds a simple --cloud-product flag to the e2e with no enforcement of
validity.

* Adds a SkipOnCloudProduct convenience function, and 2 callers.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cef9e219-9a6b-4253-b3b0-3a532636b19f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2886/head:pr_2886 && git checkout pr_2886
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-b1a750d-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f9fee748-896b-4f4c-8b7f-ec081227d907

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2886/head:pr_2886 && git checkout pr_2886
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-c02de7e-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jan 6, 2023
@roberthbailey roberthbailey merged commit 961d8ae into googleforgames:main Jan 6, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn deleted the e2e-integration branch January 9, 2023 18:50
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants