flaky/TestFleetRollingUpdate #2902

markmandel · 2023-01-12T22:27:31Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Looks like the issue is that sometimes the test can't update the Fleet, so added some logging to see if we can see why.

Also:

Updated deprecated methods
Removed parallel for subtests (see if that makes things more stable).

Which issue(s) this PR fixes:

Work on #2522

Special notes for your reviewer:

Looks like the issue is that sometimes the test can't update the Fleet, so added some logging to see if we can see why. Also: * Updated deprecated methods * Removed parallel for subtests (see if that makes things more stable). Work on googleforgames#2522

agones-bot · 2023-01-12T23:00:27Z

Build Failed 😱

Build Id: c3870a7a-e07d-499f-b587-a1d200e2e0c0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-01-12T23:52:53Z

e2e log Still failing.

Grepped e2e Log


time="2023-01-12 22:53:54.775" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0tz8nf test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:53:56.584" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:00.961" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:04.960" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:07.761" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:10.560" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:12.761" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:16.959" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:21.560" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:24.996" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0tz8nf test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:27.788" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:32.760" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:8 ReadyReplicas:4 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:36.562" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:8 ReadyReplicas:6 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:54:40.360" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:55:55.598" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0tz8nf test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:55:58.160" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0tz8nf fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:55:58.160" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0tz8nf test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_false"
time="2023-01-12 22:56:05.794" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0zvx6l test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:08.393" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:12.960" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:15.600" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0zvx6l test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:17.360" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:21.456" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:8 ReadyReplicas:5 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:25.117" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:56:59.997" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0zvx6l test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:57:01.160" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0zvx6l fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:57:01.160" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0zvx6l test="TestFleetRollingUpdate/Use_fleet_Patch_true_10%_cycle_false"
time="2023-01-12 22:57:03.000" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0cfdh9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:03.381" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:0 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:05.445" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:07.452" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:07.648" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0cfdh9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:07.712" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:09.963" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:11.776" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:3 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:13.777" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:6 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:15.779" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:7 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:17.775" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:48.743" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0cfdh9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:48.806" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:50.894" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0cfdh9 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:50.894" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0cfdh9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_25%_cycle_false"
time="2023-01-12 22:57:51.434" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.069vh7 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:51.526" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:0 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:53.596" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:55.592" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:55.772" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.069vh7 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:55.835" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:57.900" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:57:59.902" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:8 ReadyReplicas:2 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:01.903" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:8 ReadyReplicas:7 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:03.902" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:31.882" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.069vh7 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:31.973" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:34.047" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.069vh7 fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:34.047" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.069vh7 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
time="2023-01-12 22:58:34.302" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0x2nmk test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:34.389" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:0 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:36.456" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:38.458" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:38.553" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0x2nmk test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:38.614" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:1 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:40.681" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:42.681" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:1 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:44.683" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:3 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:46.686" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:3 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:48.683" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:3 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:50.677" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:6 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:52.681" level=info msg="Checking Fleet Ready replicas" expected=8 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:8 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:58:52.744" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0x2nmk test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:59:58.597" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0x2nmk test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 22:59:58.659" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:8 ReadyReplicas:2 ReservedReplicas:0 AllocatedReplicas:4 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:00.726" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:4 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:4 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:02.725" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:3 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:3 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:04.727" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:2 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:2 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:06.723" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:2 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:2 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:08.725" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:1 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
time="2023-01-12 23:00:10.724" level=info msg="Checking Fleet Ready replicas" expected=1 fleet=simple-fleet-1.0x2nmk fleetStatus="{Replicas:1 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:}" test="TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true"
agones.dev/agones/test/e2e.TestFleetRollingUpdate(0x0?)
agones.dev/agones/test/e2e.TestFleetRollingUpdate.func1(0xc00079f1e0)

It fails with Fleet simple-fleet-1.0x2nmk, but if I look at that Fleet yaml in the e2e cluster, it has 1 Ready GameServer like it is supposed to. Is it just that the test takes longer than 10 minutes?

apiVersion: agones.dev/v1
kind: Fleet
metadata:
  annotations:
    agones.dev/sdk-version: 1.29.0-2a238bf
  creationTimestamp: "2023-01-12T22:58:34Z"
  generateName: simple-fleet-1.0
  generation: 4
  name: simple-fleet-1.0x2nmk
  namespace: "1673563811"
  resourceVersion: "8625554"
  uid: 78df8f7f-f8ea-4aec-bb08-227b0ed1aba2
spec:
  replicas: 1
  scheduling: Packed
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
    spec:
      container: game-server
      health: {}
      ports:
        - containerPort: 7655
          name: udp-port
          portPolicy: Dynamic
          protocol: UDP
      sdkServer: {}
      template:
        metadata:
          creationTimestamp: null
        spec:
          containers:
            - image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.14
              imagePullPolicy: IfNotPresent
              name: game-server
              resources:
                limits:
                  cpu: 30m
                  memory: 32Mi
                requests:
                  cpu: 30m
                  memory: 32Mi
status:
  allocatedReplicas: 0
  readyReplicas: 1
  replicas: 1
  reservedReplicas: 0

agones-bot · 2023-01-13T00:28:59Z

Build Succeeded 👏

Build Id: b21d8b44-fda1-4551-993e-770b28d60a85

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-5687cdf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-5687cdf-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-5687cdf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-5687cdf-amd64
Linux C++ SDK (build): agonessdk-1.29.0-5687cdf-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-5687cdf-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5687cdf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-5687cdf-amd64

agones-bot · 2023-01-13T00:55:38Z

Build Failed 😱

Build Id: 5422e224-5549-43e9-be2b-59ab4ede2ea8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-01-13T05:14:00Z

That's a new flake.

--- FAIL: TestDevelopmentGameServerLifecycle (17.25s)
    gameserver_test.go:539: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserver_test.go:539
        	Error:      	Not equal: 
        	            	expected: "udp-servergxp6z"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-udp-servergxp6z
        	            	+
        	Test:       	TestDevelopmentGameServerLifecycle

agones-bot · 2023-01-13T05:47:35Z

Build Succeeded 👏

Build Id: 888b7d8d-8ab7-4c88-91b5-14fc5da3ed01

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-94df655-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-94df655-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-94df655-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-94df655-amd64
Linux C++ SDK (build): agonessdk-1.29.0-94df655-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-94df655-amd64.zip

A preview of the website (the last 30 builds are retained):

https://94df655-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-94df655-amd64

agones-bot · 2023-01-13T06:32:23Z

Build Succeeded 👏

Build Id: 6e90a630-75f9-4eec-a562-ffdd39fa3315

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-bf7a11e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-bf7a11e-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-bf7a11e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-bf7a11e-amd64
Linux C++ SDK (build): agonessdk-1.29.0-bf7a11e-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-bf7a11e-amd64.zip

A preview of the website (the last 30 builds are retained):

https://bf7a11e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-bf7a11e-amd64

agones-bot · 2023-01-13T18:17:22Z

Build Succeeded 👏

Build Id: 5b4a73d2-d172-43e8-b04c-1e8d4b0b710e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-19f3032-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-19f3032-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-19f3032-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-19f3032-amd64
Linux C++ SDK (build): agonessdk-1.29.0-19f3032-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-19f3032-amd64.zip

A preview of the website (the last 30 builds are retained):

https://19f3032-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-19f3032-amd64

agones-bot · 2023-01-13T20:24:21Z

Build Succeeded 👏

Build Id: 1c609427-8251-4fc1-9d8e-882283645555

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-19f3032-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-19f3032-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-19f3032-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-19f3032-amd64
Linux C++ SDK (build): agonessdk-1.29.0-19f3032-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-19f3032-amd64.zip

A preview of the website (the last 30 builds are retained):

https://19f3032-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-19f3032-amd64

markmandel · 2023-01-13T20:28:31Z

Once RC is out, I think this is good to go. Probably should merge this before #2904 though.

zmerlynn · 2023-01-13T20:32:55Z

FWIW, my intent with #2904 is not to paper over the flakes - but we still need to figure out how to report them. It'll probably end up something we have to do a bit adhoc (through logs download / rummaging).

markmandel · 2023-01-13T20:34:33Z

My point is I believe/hope this actually fixes the flaky issue. The test just sometimes needs some more time to complete - that's really about it.

zmerlynn

LGTM, honestly don't mind this going in during RC. I think it meets the criteria for a bug fix - I'll leave it up to you

google-oss-prow · 2023-01-13T20:36:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

markmandel · 2023-01-13T21:34:34Z

Yeah we're just in the middle of doing the RC release process. Once that is done, I agree - this can be merged.

google-oss-prow · 2023-01-19T00:32:31Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-01-19T01:04:41Z

Build Succeeded 👏

Build Id: cf38a3ea-18c3-42f1-9992-7efe93c98e4b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-599e82c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-599e82c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-599e82c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-599e82c-amd64
Linux C++ SDK (build): agonessdk-1.30.0-599e82c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-599e82c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://599e82c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2902/head:pr_2902 && git checkout pr_2902
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-599e82c-amd64

markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 12, 2023

google-oss-prow bot added the size/S label Jan 12, 2023

google-oss-prow bot requested review from dzlier-gcp and roberthbailey January 12, 2023 22:27

google-oss-prow bot added the approved label Jan 12, 2023

markmandel force-pushed the flaky/TestFleetRollingUpdate branch from 5687cdf to 94df655 Compare January 13, 2023 05:16

markmandel force-pushed the flaky/TestFleetRollingUpdate branch from 94df655 to bf7a11e Compare January 13, 2023 06:00

* Increase e2e test timeout to 30m.

19f3032

markmandel force-pushed the flaky/TestFleetRollingUpdate branch from bf7a11e to 19f3032 Compare January 13, 2023 17:43

markmandel changed the title ~~Attempt at flaky/TestFleetRollingUpdate~~ flaky/TestFleetRollingUpdate Jan 13, 2023

markmandel requested a review from zmerlynn January 13, 2023 20:28

zmerlynn self-assigned this Jan 13, 2023

zmerlynn approved these changes Jan 13, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Jan 13, 2023

Kalaiselvi84 added feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) and removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Jan 17, 2023

markmandel enabled auto-merge (squash) January 19, 2023 00:32

Merge branch 'main' into flaky/TestFleetRollingUpdate

599e82c

google-oss-prow bot removed the lgtm label Jan 19, 2023

markmandel merged commit 1ed56e6 into googleforgames:main Jan 19, 2023

markmandel deleted the flaky/TestFleetRollingUpdate branch January 19, 2023 01:04

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flaky/TestFleetRollingUpdate #2902

flaky/TestFleetRollingUpdate #2902

markmandel commented Jan 12, 2023

agones-bot commented Jan 12, 2023

markmandel commented Jan 12, 2023 •

edited

Loading

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

zmerlynn commented Jan 13, 2023

markmandel commented Jan 13, 2023

zmerlynn left a comment

google-oss-prow bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

google-oss-prow bot commented Jan 19, 2023

agones-bot commented Jan 19, 2023

flaky/TestFleetRollingUpdate #2902

flaky/TestFleetRollingUpdate #2902

Conversation

markmandel commented Jan 12, 2023

agones-bot commented Jan 12, 2023

markmandel commented Jan 12, 2023 • edited Loading

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

agones-bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

zmerlynn commented Jan 13, 2023

markmandel commented Jan 13, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jan 13, 2023

markmandel commented Jan 13, 2023

google-oss-prow bot commented Jan 19, 2023

agones-bot commented Jan 19, 2023

markmandel commented Jan 12, 2023 •

edited

Loading