Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GKE Workload Identity flag to GKE Terraform modules #2928

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Added GKE Workload Identity flag to GKE Terraform modules #2928

merged 3 commits into from
Jan 25, 2023

Conversation

abmarcum
Copy link
Contributor

This adds a workload_id flag for both the gke & gke-autopilot Terraform modules. If the option is set to true, this will enable the Workload Identity GKE feature through the associated Terraform GKE option.

By default, this option is set to false and Workload Identity will not be enabled on the GKE cluster.

This option is being added so that Allocation Endpoints can be run on GKE clusters provisioned by the Agones Terraform GKE modules.

Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

install/terraform/modules/gke-autopilot/cluster.tf Outdated Show resolved Hide resolved
install/terraform/modules/gke/cluster.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 25, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abmarcum, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval by writing /assign @cyriltovena in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) January 25, 2023 17:06
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 981be633-1ea4-43f1-a2e0-1da1b9da5f7a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2928/head:pr_2928 && git checkout pr_2928
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-d8497ac-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1b2979d3-de9d-4437-9175-481c8f6c48e7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2928/head:pr_2928 && git checkout pr_2928
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-439b9bc-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f6ae6387-e77d-4ccc-9895-6140a4607679

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2928/head:pr_2928 && git checkout pr_2928
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-3499989-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 25, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1e40fd9c-8563-4a97-a3ef-4aabbf80c4df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2928/head:pr_2928 && git checkout pr_2928
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-b9583ab-amd64

@zmerlynn zmerlynn merged commit e6c5718 into googleforgames:main Jan 25, 2023
igooch pushed a commit to igooch/agones that referenced this pull request Jan 31, 2023
…ames#2928)

Added GKE Workload Identity flag to GKE Terraform modules
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants