Add e2e test for Extensions #2947

chiayi · 2023-02-02T22:36:25Z

Adds an E2E test for testing high availability extensions.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Part of HA Agones. Adds an e2e test that will test high availability by deleting one of the extensions pod and creating a gameserver.

Which issue(s) this PR fixes:
Work on #2797

Special notes for your reviewer:

agones-bot · 2023-02-02T22:41:53Z

Build Failed 😱

Build Id: 7f2d243c-5364-40e7-a80f-200f6b648751

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-02T23:24:18Z

Build Succeeded 👏

Build Id: de8179f4-e552-4fe6-bff9-01b5c8ccde2b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-6a78a3b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-6a78a3b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-6a78a3b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-6a78a3b-amd64
Linux C++ SDK (build): agonessdk-1.30.0-6a78a3b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-6a78a3b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6a78a3b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6a78a3b-amd64

agones-bot · 2023-02-03T01:14:28Z

Build Succeeded 👏

Build Id: 8e65e5ac-3dc5-4339-a362-f6a28bc89ee1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-d87b344-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-d87b344-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-d87b344-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-d87b344-amd64
Linux C++ SDK (build): agonessdk-1.30.0-d87b344-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-d87b344-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d87b344-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-d87b344-amd64

agones-bot · 2023-02-03T01:42:39Z

Build Succeeded 👏

Build Id: 3016787c-4f6f-459c-a4a5-38c94575da33

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-2d38ee8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-2d38ee8-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-2d38ee8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-2d38ee8-amd64
Linux C++ SDK (build): agonessdk-1.30.0-2d38ee8-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-2d38ee8-amd64.zip

A preview of the website (the last 30 builds are retained):

https://2d38ee8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-2d38ee8-amd64

agones-bot · 2023-02-03T19:08:22Z

Build Failed 😱

Build Id: fcab7a59-4821-47cd-b79d-83f7eba4a238

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-03T19:24:15Z

Build Succeeded 👏

Build Id: b976e379-41bf-43d5-ba66-e7d5621294fd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-6d62674-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-6d62674-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-6d62674-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-6d62674-amd64
Linux C++ SDK (build): agonessdk-1.30.0-6d62674-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-6d62674-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6d62674-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6d62674-amd64

agones-bot · 2023-02-03T19:40:19Z

Build Failed 😱

Build Id: 1274e469-4b66-45bd-9e34-f72e3770ef64

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-03T20:27:21Z

Build Succeeded 👏

Build Id: 3437bcd4-2222-4bd3-a54e-afbf146bd2ca

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-26a361d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-26a361d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-26a361d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-26a361d-amd64
Linux C++ SDK (build): agonessdk-1.30.0-26a361d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-26a361d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://26a361d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-26a361d-amd64

agones-bot · 2023-02-03T22:25:01Z

Build Succeeded 👏

Build Id: 43a885e2-293a-4b9a-9999-33a6a9c0edbd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-0837dc4-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-0837dc4-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-0837dc4-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-0837dc4-amd64
Linux C++ SDK (build): agonessdk-1.30.0-0837dc4-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-0837dc4-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0837dc4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-0837dc4-amd64

agones-bot · 2023-02-03T22:53:41Z

Build Succeeded 👏

Build Id: feb60f68-9643-48ad-b6cb-b2c81d8e57f3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-883ee6f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-883ee6f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-883ee6f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-883ee6f-amd64
Linux C++ SDK (build): agonessdk-1.30.0-883ee6f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-883ee6f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://883ee6f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-883ee6f-amd64

zmerlynn · 2023-02-03T23:35:37Z

build/Makefile

@@ -354,6 +355,24 @@ else
 endif
 	echo "Finishing e2e controller failure test!"

+test-e2e-ha-extensions: FEATURE_GATES ?= $(ALPHA_FEATURE_GATES)


Non-blocking: I would like us to look at reducing redundancy here since we're repeating ourselves a lot. It's not clear to me that the original split couldn't be done a different way - it might be nice to try folding all of this back into the main e2e package. But certainly this is fine for this PR.

zmerlynn · 2023-02-03T23:36:40Z

test/e2e/extensions/high_availability_test.go

+	ctx := context.Background()
+
+	if !runtime.FeatureEnabled(runtime.FeatureSplitControllerAndExtensions) {
+		logger.Infof("Skip test. SplitControllerAndExtensions feature is not enabled: flag is %v", runtime.FeatureEnabled(runtime.FeatureSplitControllerAndExtensions))


Use t.Skip() here: https://pkg.go.dev/testing#hdr-Skipping

zmerlynn · 2023-02-03T23:40:13Z

test/e2e/extensions/high_availability_test.go

+	logger.WithField("gsKey", readyGs.ObjectMeta.Name).Info("GameServer Ready")
+
+	gsClient := framework.AgonesClient.AgonesV1().GameServers(defaultNs)
+	defer gsClient.Delete(ctx, readyGs.ObjectMeta.Name, metav1.DeleteOptions{}) // nolint: errcheck


since it's literally the last thing we do it's a little funny to defer it. Plus you can just collapse the helper variable here, and re-lintcheck it. So:

assert.NoError(t, framework.AgonesClient.AgonesV1().GameServers(defaultNs).Delete( ctx, readyGs.ObjectMeta.Name, metav1.DeleteOptions{})

Yup it is 😅 combined the lines.

zmerlynn · 2023-02-03T23:44:02Z

test/e2e/extensions/high_availability_test.go

+// faking a extensions pod crash.
+func deleteAgonesExtensionsPods(ctx context.Context) error {
+	list, err := getAgoneseExtensionsPods(ctx)
+	if err != nil {


here and below, I'd be inclined to throw in a t *testing.T parameter and just use assert.NoError(t, err). Keeps it more concise and better tracks the line number of failures.

Done! As for the method below waitForAgonesExtensionsRunning, I don't think it makes sense to add t *testing.T as it won't be able to use it since it still needs to return the bool.

zmerlynn · 2023-02-03T23:44:32Z

test/e2e/extensions/high_availability_test.go

+
+	list, err := getAgoneseExtensionsPods(ctx)
+	logger.Infof("Length of pod list is %v", len(list.Items))
+	if err != nil {


Use assert.NoError here.

zmerlynn · 2023-02-03T23:48:28Z

test/e2e/extensions/high_availability_test.go

+	if err != nil {
+		t.Fatalf("Could not get list of Extension pods: %v", err)
+	}
+	if len(list.Items) <= 1 {


Use assert.Greater. The message is nice, though, so you can keep:

assert.Greater(list.Items, 1, "Cluster has zero or one extension pods")

Oh thats neat, I did not know this was an option.

zmerlynn · 2023-02-03T23:48:39Z

test/e2e/extensions/high_availability_test.go

+	logger.Info("Creating default game server")
+	gs := framework.DefaultGameServer(defaultNs)
+	readyGs, err := framework.CreateGameServerAndWaitUntilReady(t, defaultNs, gs)
+	if err != nil {


assert.NoError()

agones-bot · 2023-02-06T21:51:15Z

Build Failed 😱

Build Id: bcd43570-9a7a-4eca-9d62-aa0244e2e301

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-06T21:58:26Z

Build Failed 😱

Build Id: a8c90adb-ad7f-4479-915b-0bad7ee5f014

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Started e2e test for extensions

agones-bot · 2023-02-06T22:40:37Z

Build Succeeded 👏

Build Id: 7793eb64-aef5-43a0-a2d9-2592cb4bdf62

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-def9b4f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-def9b4f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-def9b4f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-def9b4f-amd64
Linux C++ SDK (build): agonessdk-1.30.0-def9b4f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-def9b4f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://def9b4f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2947/head:pr_2947 && git checkout pr_2947
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-def9b4f-amd64

google-oss-prow · 2023-02-06T22:55:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign roberthbailey for approval by writing /assign @roberthbailey in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added the do-not-merge/work-in-progress label Feb 2, 2023

google-oss-prow bot requested review from aLekSer and EricFortin February 2, 2023 22:36

google-oss-prow bot added the size/L label Feb 2, 2023

chiayi force-pushed the main branch from e01c36f to 6a78a3b Compare February 2, 2023 22:45

chiayi force-pushed the main branch 2 times, most recently from d87b344 to 2d38ee8 Compare February 3, 2023 00:30

chiayi force-pushed the main branch 2 times, most recently from 6d62674 to f2e91f4 Compare February 3, 2023 18:59

chiayi force-pushed the main branch from f2e91f4 to 70b5a64 Compare February 3, 2023 19:34

chiayi force-pushed the main branch from 70b5a64 to 26a361d Compare February 3, 2023 19:42

chiayi force-pushed the main branch 2 times, most recently from 0837dc4 to 883ee6f Compare February 3, 2023 22:02

chiayi marked this pull request as ready for review February 3, 2023 22:25

google-oss-prow bot removed the do-not-merge/work-in-progress label Feb 3, 2023

google-oss-prow bot requested review from cyriltovena and dzlier-gcp February 3, 2023 22:25

chiayi requested review from zmerlynn and roberthbailey and removed request for cyriltovena and EricFortin February 3, 2023 22:25

chiayi requested review from markmandel and removed request for aLekSer and dzlier-gcp February 3, 2023 22:25

zmerlynn requested changes Feb 3, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn Feb 3, 2023

chiayi force-pushed the main branch from 883ee6f to 6538c7e Compare February 6, 2023 21:45

chiayi force-pushed the main branch from 6538c7e to 342907a Compare February 6, 2023 21:52

Add e2e test for extensions

def9b4f

Started e2e test for extensions

chiayi force-pushed the main branch from 342907a to def9b4f Compare February 6, 2023 22:03

chiayi requested a review from zmerlynn February 6, 2023 22:52

zmerlynn approved these changes Feb 6, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Feb 6, 2023

zmerlynn merged commit f7a7472 into googleforgames:main Feb 6, 2023

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e test for Extensions #2947

Add e2e test for Extensions #2947

chiayi commented Feb 2, 2023 •

edited

Loading

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

zmerlynn Feb 3, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

zmerlynn Feb 3, 2023

chiayi Feb 6, 2023

agones-bot commented Feb 6, 2023

agones-bot commented Feb 6, 2023

agones-bot commented Feb 6, 2023

google-oss-prow bot commented Feb 6, 2023

Add e2e test for Extensions #2947

Add e2e test for Extensions #2947

Conversation

chiayi commented Feb 2, 2023 • edited Loading

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

agones-bot commented Feb 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Feb 6, 2023

agones-bot commented Feb 6, 2023

agones-bot commented Feb 6, 2023

google-oss-prow bot commented Feb 6, 2023

chiayi commented Feb 2, 2023 •

edited

Loading