Add error callback to testSDKClient

[steven-supersolid]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Adds an error callback to watchGameServer so that errors can be caught during watching

Which issue(s) this PR fixes:

Closes #2954

Special notes for your reviewer:

[steven-supersolid]

/cc zmerlynn

[agones-bot]

Build Failed 😱

Build Id: 0e9c2fb9-eab4-4fb0-83d6-65542e703bef

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[gongmax]

I was recreating the test clusters which made the CI fail. I will retry this build after the test clusters are created.

[agones-bot]

Build Failed 😱

Build Id: 0ea987ef-f0ea-4328-b60c-1ab4b19a58b3

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: c407c6a3-b2d6-431b-b2a8-e34f42c31a35

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: ce2cd3fa-cd01-45d6-97e0-9609dde4dc89

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 271463e5-c97f-4797-aaca-da96a70420c9

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-dd265fd-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-dd265fd-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-dd265fd-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-dd265fd-amd64
• Linux C++ SDK (build): agonessdk-1.30.0-dd265fd-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.30.0-dd265fd-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://dd265fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2964/head:pr_2964 && git checkout pr_2964
• helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-dd265fd-amd64

[steven-supersolid]

I greatly appreciate any help reproducing this @gongmax. I don't how to reproduce the error and as on Windows I'm not sure if possible to reproduce the error e.g. not all the Make scripts work for me 100% of the time

[markmandel]

@steven-supersolid can you rebase against main and push please? Because you are on an org fork, we can't update on our end. (automerge is enabled, so you should only have to do this once).

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Succeeded 👏

Build Id: 9b2cea1a-2873-41e0-8eb4-64077706b7b2

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-fb8c1e5-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-fb8c1e5-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-fb8c1e5-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-fb8c1e5-amd64
• Linux C++ SDK (build): agonessdk-1.30.0-fb8c1e5-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.30.0-fb8c1e5-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://fb8c1e5-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2964/head:pr_2964 && git checkout pr_2964
• helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-fb8c1e5-amd64