Run e2e tests on multiple clusters with different versions #2968

gongmax · 2023-02-14T00:17:39Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2023-02-14T00:35:58Z

Build Failed 😱

Build Id: f0b8dfe7-f457-4b45-bfdb-97442407bed8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T01:11:30Z

Build Failed 😱

Build Id: 1a8490d5-8912-4373-a175-6184dd9dab44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T02:45:16Z

Build Failed 😱

Build Id: 500580c1-5ec1-4e3d-9785-b1884fdaf7b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T07:58:27Z

Build Failed 😱

Build Id: 607e604e-8447-47dc-bae3-c9cdb4e7a609

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T09:04:59Z

Build Succeeded 👏

Build Id: cd8cff5f-6b90-48fc-b99c-54acb57c5393

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-0e9fac5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-0e9fac5-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-0e9fac5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-0e9fac5-amd64
Linux C++ SDK (build): agonessdk-1.30.0-0e9fac5-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-0e9fac5-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0e9fac5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2968/head:pr_2968 && git checkout pr_2968
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-0e9fac5-amd64

agones-bot · 2023-02-14T18:28:32Z

Build Failed 😱

Build Id: 24cc83a0-0e18-4fd0-8d6e-f468ceea0f72

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T19:35:52Z

Build Failed 😱

Build Id: 33380f49-b513-4325-9fab-e105b60109dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-14T23:48:35Z

Build Failed 😱

Build Id: e2e50ffe-74bc-45bf-b5ef-b504b21adfe2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-15T01:23:09Z

Build Succeeded 👏

Build Id: f7ca00b2-a2a4-4e84-8d9c-f23c6ef04cd6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-c722831-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-c722831-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-c722831-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-c722831-amd64
Linux C++ SDK (build): agonessdk-1.30.0-c722831-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-c722831-amd64.zip

A preview of the website (the last 30 builds are retained):

https://c722831-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2968/head:pr_2968 && git checkout pr_2968
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-c722831-amd64

agones-bot · 2023-02-15T20:51:00Z

Build Failed 😱

Build Id: 3bed76a0-19c4-4a01-8836-25362601a959

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-15T21:45:35Z

Build Succeeded 👏

Build Id: 78e92276-1872-4a87-91e4-9be0e5d41c26

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-29becca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-29becca-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-29becca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-29becca-amd64
Linux C++ SDK (build): agonessdk-1.30.0-29becca-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-29becca-amd64.zip

A preview of the website (the last 30 builds are retained):

https://29becca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2968/head:pr_2968 && git checkout pr_2968
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-29becca-amd64

cloudbuild.yaml

agones-bot · 2023-02-16T00:58:11Z

Build Succeeded 👏

Build Id: b3cd2858-4d3f-4719-9b05-12f2d3ba06d8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-aca0cb7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-aca0cb7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-aca0cb7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-aca0cb7-amd64
Linux C++ SDK (build): agonessdk-1.30.0-aca0cb7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-aca0cb7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://aca0cb7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2968/head:pr_2968 && git checkout pr_2968
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-aca0cb7-amd64

agones-bot · 2023-02-16T02:26:27Z

Build Succeeded 👏

Build Id: f59656ad-13c4-48d3-a0ed-b891a4a18346

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-88c9b7c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-88c9b7c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-88c9b7c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-88c9b7c-amd64
Linux C++ SDK (build): agonessdk-1.30.0-88c9b7c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-88c9b7c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://88c9b7c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2968/head:pr_2968 && git checkout pr_2968
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-88c9b7c-amd64

roberthbailey · 2023-02-16T06:34:32Z

cloudbuild.yaml

+            featureWithGate="CustomFasSyncInterval=false&SafeToEvict=false&SDKGracefulTermination=false&StateAllocationFilter=false&PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=true&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&Example=true"
+            featureWithoutGate=""
+            testClusterLocation="${region}-c"
+            testCluster="gke-standard-e2e-test-cluster-${version//./-}"


nit: Maybe something to consider in the future would be to name the clusters as "${cloudProduct}-e2e-test-cluster-${version//./-}". So we'd have names like generic-e2e-test-cluster-1-24 and gke-autopilot-e2e-test-cluster-1-24.

I'm thinking that once a couple of feature gates get promoted to beta, we won't need the if/else here for feature gates based on the provider, and if we move to regional standard clusters then the only difference remaining is how we construct the test cluster names.

google-oss-prow · 2023-02-16T06:34:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roberthbailey · 2023-02-16T06:34:50Z

Here we go.....

Run e2e tests on multiple clusters with different versions

4872ae1

google-oss-prow bot added the do-not-merge/work-in-progress label Feb 14, 2023

google-oss-prow bot requested review from dzlier-gcp and markmandel February 14, 2023 00:17

google-oss-prow bot added the size/M label Feb 14, 2023

Differentiate region

e456895

fix broken test

81e6b8d

fix

0e9fac5

Merge branch 'main' into ci-e2e-test

4d28136

Merge branch 'main' into ci-e2e-test

c722831

gongmax marked this pull request as ready for review February 15, 2023 01:38

google-oss-prow bot removed the do-not-merge/work-in-progress label Feb 15, 2023

google-oss-prow bot requested a review from cyriltovena February 15, 2023 01:38

gongmax requested review from roberthbailey and removed request for cyriltovena and dzlier-gcp February 15, 2023 18:45

Merge branch 'main' into ci-e2e-test

29becca

Merge branch 'main' into ci-e2e-test

aca0cb7

roberthbailey reviewed Feb 15, 2023

View reviewed changes

cloudbuild.yaml Outdated Show resolved Hide resolved

cloudbuild.yaml Outdated Show resolved Hide resolved

gongmax added 2 commits February 16, 2023 01:36

Make version and region pairs

c91934a

fix typo

88c9b7c

roberthbailey approved these changes Feb 16, 2023

View reviewed changes

google-oss-prow bot assigned roberthbailey Feb 16, 2023

google-oss-prow bot added the lgtm label Feb 16, 2023

google-oss-prow bot added the approved label Feb 16, 2023

roberthbailey merged commit 1e7cd82 into googleforgames:main Feb 16, 2023

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run e2e tests on multiple clusters with different versions #2968

Run e2e tests on multiple clusters with different versions #2968

gongmax commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 16, 2023

agones-bot commented Feb 16, 2023

roberthbailey Feb 16, 2023

google-oss-prow bot commented Feb 16, 2023

roberthbailey commented Feb 16, 2023

Run e2e tests on multiple clusters with different versions #2968

Run e2e tests on multiple clusters with different versions #2968

Conversation

gongmax commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 14, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 15, 2023

agones-bot commented Feb 16, 2023

agones-bot commented Feb 16, 2023

roberthbailey Feb 16, 2023

Choose a reason for hiding this comment

google-oss-prow bot commented Feb 16, 2023

roberthbailey commented Feb 16, 2023