Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create e2e test clusters in different regions to mitigate quota limit issue #2969

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Feb 14, 2023

… issue

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Two changes in this PR:

  • In e2e test cluster module, make location a variable so we can create the clusters in different region to mitigate quota limit issue
  • For the version field in the GKE node pool, while a fuzzy version can be specified, Terraform will see spurious diffs when fuzzy versions are used so basically it will trigger resource change every time. Instead, this PR use the google_container_engine_versions data source's version_prefix field to approximate fuzzy versions in a Terraform-compatible way to avoid unnecessary resource update.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
New clusters has been created: https://pantheon.corp.google.com/kubernetes/list/overview?project=agones-images

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 585731ae-a91e-45ec-8f63-471335674fae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-7d796ff-amd64

@gongmax gongmax marked this pull request as ready for review February 14, 2023 18:13
@gongmax gongmax removed the request for review from aLekSer February 14, 2023 18:14
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7293062e-e3fb-4855-8aaf-3f3ddb1ea8c5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-018e5b6-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 948aa3eb-5d86-4004-b303-1d5b3b1bdf08

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 057ccd9f-ac72-4299-a7dd-5ae7c77dcec9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6699a8f-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b4e15f26-bbad-41cd-8503-16d571ecdbbf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-0355df1-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 27705cbb-76ad-4173-817d-06cddcbcede9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-bc29293-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot added approved and removed lgtm labels Feb 16, 2023
@roberthbailey roberthbailey enabled auto-merge (squash) February 16, 2023 06:40
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3bf3b982-52ba-4df2-9be3-16e2b830aba4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2969/head:pr_2969 && git checkout pr_2969
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-9ae0bfe-amd64

@roberthbailey roberthbailey merged commit 5fad7ab into googleforgames:main Feb 16, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants