-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create e2e test clusters in different regions to mitigate quota limit issue #2969
Conversation
Build Succeeded 👏 Build Id: 585731ae-a91e-45ec-8f63-471335674fae The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 7293062e-e3fb-4855-8aaf-3f3ddb1ea8c5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 948aa3eb-5d86-4004-b303-1d5b3b1bdf08 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 057ccd9f-ac72-4299-a7dd-5ae7c77dcec9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: b4e15f26-bbad-41cd-8503-16d571ecdbbf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 27705cbb-76ad-4173-817d-06cddcbcede9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 3bf3b982-52ba-4df2-9be3-16e2b830aba4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
… issue
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Two changes in this PR:
version
field in the GKE node pool, while a fuzzy version can be specified, Terraform will see spurious diffs when fuzzy versions are used so basically it will trigger resource change every time. Instead, this PR use thegoogle_container_engine_versions
data source'sversion_prefix
field to approximate fuzzy versions in a Terraform-compatible way to avoid unnecessary resource update.Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
New clusters has been created: https://pantheon.corp.google.com/kubernetes/list/overview?project=agones-images