Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extensions status dash and dash name change #3000

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add extensions status dash and dash name change #3000

merged 1 commit into from
Feb 27, 2023

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Feb 25, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Adds a separate dashboard for extensions status. It also adds Alpha to the Extensions resource dashboard name.

Which issue(s) this PR fixes:
Work on #2797

Special notes for your reviewer:
Picture of Status dashboard:
image

@chiayi chiayi requested review from markmandel, roberthbailey and zmerlynn and removed request for aLekSer and dzlier-gcp February 25, 2023 00:55
@chiayi chiayi force-pushed the metricsbranch branch 3 times, most recently from 32d03ff to 97537d8 Compare February 25, 2023 01:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0c5e1244-b1c3-4196-8195-7c96b57bb0ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3000/head:pr_3000 && git checkout pr_3000
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-985c108-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2bc67e78-af54-45b8-bdb8-015822fbbb24

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3000/head:pr_3000 && git checkout pr_3000
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-475525d-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b5121319-b0a5-4df4-ba3b-1153e8de7c67

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: abc5ce58-86cb-4248-b4dc-9981c83fd9a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3000/head:pr_3000 && git checkout pr_3000
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-32d03ff-amd64

@zmerlynn
Copy link
Collaborator

This isn't quite what I was thinking. Rather, I think we should fork the whole status dashboard as (Alpha), adding the extensions panels (which you created here) in. That way someone can just use the Alpha status dashboard as their status dashboard, if they're running Alpha gates. Does that make sense?

@chiayi
Copy link
Contributor Author

chiayi commented Feb 27, 2023

Do you mean to have another dashboard that contains all the current status along with the new Extensions panels @zmerlynn

@zmerlynn
Copy link
Collaborator

Do you mean to have another dashboard that contains all the current status along with the new Extensions panels @zmerlynn

Yes. The idea is that if you're running the feature, you use the Alpha dashboard rather than the normal one. Similarly, it means that when we graduate SplitControllerAndExtensions, we basically just copy it over the primary dashboard.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Feb 27, 2023
@chiayi
Copy link
Contributor Author

chiayi commented Feb 27, 2023

Picture of the Alpha status page:
image

zmerlynn
zmerlynn approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 27, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) February 27, 2023 19:31
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 27, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: decadafd-d4d1-40f4-996d-52a382a609b2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3000/head:pr_3000 && git checkout pr_3000
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6695ee8-amd64

@zmerlynn zmerlynn merged commit b97b2a3 into googleforgames:main Feb 27, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
This was referenced Nov 29, 2023
Open
Open
@WontonSam WontonSam mentioned this pull request Dec 20, 2023
Open
@WontonSam WontonSam mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@zmerlynn zmerlynn

Labels
kind/feature New features for Agones size/XL
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chiayi @agones-bot @zmerlynn @Kalaiselvi84