Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify instructions for Managed Prometheus #3015

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Mar 2, 2023

The instructions linked straight to the installation of the frontend UI, but that skips over the "Before you begin" section of the doc. The "Before you begin" section has a crucial step in it: authorizing the Kubernetes service account to read metrics.

The instructions linked straight to the installation of the frontend
UI, but that skips over the "Before you begin" section of the doc. The
"Before you begin" section has a crucial step in it: authorizing the
Kubernetes service account to read metrics.
@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Mar 2, 2023

cc @shannonxtreme

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e4e6d892-8b4d-4d42-8df9-e448eccd30c2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3015/head:pr_3015 && git checkout pr_3015
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-46ea64a-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Mar 2, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey enabled auto-merge (squash) March 2, 2023 23:31
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1a4a4ec6-2279-47af-975d-0af5b63c77b9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3015/head:pr_3015 && git checkout pr_3015
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-2a83508-amd64

@roberthbailey roberthbailey merged commit 43e946f into googleforgames:main Mar 3, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/documentation Documentation for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants