Generate release notes and Changelog using Github #3022

Kalaiselvi84 · 2023-03-08T23:24:21Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

b/271147150

Special notes for your reviewer:

agones-bot · 2023-03-08T23:34:23Z

Build Failed 😱

Build Id: 6ed906c3-06ea-4715-9c3a-3dc14f62de5e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

.github/release.yml

markmandel · 2023-03-09T20:05:11Z

Let's add the changes we expect to see in the release notes too please.

agones-bot · 2023-03-10T00:49:55Z

Build Failed 😱

Build Id: d04b8938-0fe2-4b50-8ba3-fb749d12b16b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-10T19:32:45Z

Build Succeeded 👏

Build Id: ff7ec30a-0584-4c2b-b338-cc6449cd8ddd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-b812be8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-b812be8-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-b812be8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-b812be8-amd64
Linux C++ SDK (build): agonessdk-1.31.0-b812be8-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-b812be8-amd64.zip

A preview of the website (the last 30 builds are retained):

https://b812be8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3022/head:pr_3022 && git checkout pr_3022
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-b812be8-amd64

agones-bot · 2023-03-11T18:41:16Z

Build Succeeded 👏

Build Id: a8187865-45b2-466d-9b0e-91bcbd72e9fe

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-b5bdeb7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-b5bdeb7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-b5bdeb7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-b5bdeb7-amd64
Linux C++ SDK (build): agonessdk-1.31.0-b5bdeb7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-b5bdeb7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://b5bdeb7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3022/head:pr_3022 && git checkout pr_3022
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-b5bdeb7-amd64

markmandel

This looks great! Nice changes overall on the release checklist (as an aside, if you ever want to make improvements, please feel free to do so).

Just some minor things, and I think this will be good for the next release 👍🏻

markmandel · 2023-03-30T22:30:10Z

.github/release.yml

+changelog:
+  exclude:
+    labels:
+      - area/meta


Suggested change

- area/meta

So I realised something - our release docs are wrong, we don't ignore area/meta at all!

markmandel · 2023-03-30T22:30:24Z

.github/release.yml

+      - question
+      - invalid
+      - wontfix
+      - priority/wontfix


Suggested change

- priority/wontfix

I don't think we have this label anywhere?

markmandel · 2023-03-30T22:31:03Z

.github/release.yml

+      - wontfix
+      - priority/wontfix
+  categories:
+    - title: Breaking Changes


Suggested change

- title: Breaking Changes

- title: Breaking changes

Just for capitalisation consistency.

markmandel · 2023-03-30T22:31:24Z

.github/release.yml

+    - title: Fixed bugs
+      labels:
+        - kind/bug
+    - title: Security


Suggested change

- title: Security

- title: Security fixes

markmandel · 2023-03-30T22:33:17Z

docs/governance/templates/release_issue.md

@@ -23,7 +23,7 @@ and copy it into a release issue. Fill in relevant values, found inside {}

 - [ ] Run `make shell` and run `gcloud config configurations activate agones-images`.
 - [ ] Review [closed issues with no milestone](https://github.com/googleforgames/agones/issues?q=is%3Aissue+is%3Aclosed+no%3Amilestone++-label%3Ainvalid+-label%3Aduplicate+-label%3Aquestion+-label%3Awontfix++-label%3Aarea%2Fmeta) and add relevant ones to the current milestone.
-    - Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` can be ignored
+  - Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` can be ignored


Suggested change

- Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` can be ignored

- Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` don't need review.

I see the confusion in this step - suggestion less ambiguous language. WDYT?

markmandel · 2023-03-30T22:55:23Z

docs/governance/templates/release_issue.md

- [ ] Move the CHANGELOG.md to the root of this repository, replacing any previous versions.
- [ ] Ensure the [helm `tag` value][values] is correct (should be {version})
- [ ] Ensure the [helm `Chart` version values][chart] are correct (should be {version})
+      -For example, if you are creating the {version} release, then you would deploy the {version}-1 service (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service]


Suggested change

-For example, if you are creating the {version} release, then you would deploy the {version}-1 service (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service]

- For example, if you are creating the {version} release, then this would deploy the {version}-1 service (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service]

Also was the part in (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service] meant to be a markdown link?

It isn't a link, just to confirm the successful deployment in the app engine/ service. Added almost all the steps from the release video here😀

markmandel · 2023-03-30T22:58:11Z

docs/governance/templates/release_issue.md

 - [ ] Change to the `sdks/nodejs` directory and run the command `npm version {version}+1-dev` to update the package version
 - [ ] Move the [`sdks/csharp/sdk/AgonesSDK.nuspec` and `sdks/csharp/sdk/csharp-sdk.csproj`][csharp] to {version}+1-dev
- [ ] Update the [`sdks/unity/package.json`][unity] package file's `Version` field to {version}+1-dev
+- [ ] Update the [`sdks/unity/package.json`][unity] package file's `version` field to {version}+1-dev


Since we're fixing things, can we add a link to [unity] down below, so we finally don't have a broken markdown link 😄

agones-bot · 2023-03-31T01:20:32Z

Build Succeeded 👏

Build Id: 4a3cdffb-7987-4d9f-a66a-a0648e5bf7bf

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-a44319d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-a44319d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-a44319d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-a44319d-amd64
Linux C++ SDK (build): agonessdk-1.31.0-a44319d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-a44319d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a44319d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3022/head:pr_3022 && git checkout pr_3022
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-a44319d-amd64

google-oss-prow · 2023-03-31T16:52:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-03-31T16:53:09Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-03-31T17:54:13Z

Build Succeeded 👏

Build Id: 6ba72262-4e06-484e-b186-06fe161a6883

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-534115c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-534115c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-534115c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-534115c-amd64
Linux C++ SDK (build): agonessdk-1.31.0-534115c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-534115c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://534115c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3022/head:pr_3022 && git checkout pr_3022
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-534115c-amd64

* Generate release notes using Github * Apache header included * update in release checklist * del a extra space * fmt file * few changes in the checklist * Changes in release files

Generate release notes using Github

0000462

Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 8, 2023

Kalaiselvi84 added this to the 1.31.0 milestone Mar 8, 2023

Kalaiselvi84 requested review from markmandel and roberthbailey March 8, 2023 23:24

google-oss-prow bot requested a review from EricFortin March 8, 2023 23:24

google-oss-prow bot added the size/S label Mar 8, 2023

markmandel reviewed Mar 9, 2023

View reviewed changes

.github/release.yml Show resolved Hide resolved

Apache header included

a27466b

google-oss-prow bot added size/M and removed size/S labels Mar 10, 2023

Kalaiselvi84 added 3 commits March 10, 2023 18:33

update in release checklist

259724b

del a extra space

9a413a6

fmt file

b812be8

google-oss-prow bot added size/L and removed size/M labels Mar 10, 2023

few changes in the checklist

b5bdeb7

markmandel reviewed Mar 30, 2023

View reviewed changes

Changes in release files

a44319d

markmandel approved these changes Mar 31, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Mar 31, 2023

google-oss-prow bot added the lgtm label Mar 31, 2023

google-oss-prow bot added the approved label Mar 31, 2023

markmandel enabled auto-merge (squash) March 31, 2023 16:52

Merge branch 'main' into issues/271147150

534115c

google-oss-prow bot removed the lgtm label Mar 31, 2023

markmandel merged commit d80264d into googleforgames:main Mar 31, 2023

gongmax mentioned this pull request Apr 26, 2023

Consider using the new github release notes #2299

Closed

Kalaiselvi84 deleted the issues/271147150 branch March 15, 2024 01:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate release notes and Changelog using Github #3022

Generate release notes and Changelog using Github #3022

Kalaiselvi84 commented Mar 8, 2023

agones-bot commented Mar 8, 2023

markmandel commented Mar 9, 2023

agones-bot commented Mar 10, 2023

agones-bot commented Mar 10, 2023

agones-bot commented Mar 11, 2023

markmandel left a comment

markmandel Mar 30, 2023

markmandel Mar 30, 2023

markmandel Mar 30, 2023

markmandel Mar 30, 2023

markmandel Mar 30, 2023

markmandel Mar 30, 2023

Kalaiselvi84 Mar 30, 2023

markmandel Mar 30, 2023

agones-bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

agones-bot commented Mar 31, 2023

	- Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` can be ignored
	- Issues tagged as `invalid`, `duplicate`, `question`, `wontfix`, or `area/meta` don't need review.

	-For example, if you are creating the {version} release, then you would deploy the {version}-1 service (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service]
	- For example, if you are creating the {version} release, then this would deploy the {version}-1 service (release minus one, and then replace dots with dashes) [check for this change in GCP -> App Engine/Service]

Generate release notes and Changelog using Github #3022

Generate release notes and Changelog using Github #3022

Conversation

Kalaiselvi84 commented Mar 8, 2023

agones-bot commented Mar 8, 2023

markmandel commented Mar 9, 2023

agones-bot commented Mar 10, 2023

agones-bot commented Mar 10, 2023

agones-bot commented Mar 11, 2023

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

agones-bot commented Mar 31, 2023