Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GKE Autopilot auto-detection for 1.26 #3032

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

zmerlynn
Copy link
Collaborator

The workload-defaulter no longer exists as a standalone webhook on 1.26 - instead use the new warden-mutating webhook. I am following up internally with finding a less brittle way to do this.

The `workload-defaulter` no longer exists as a standalone webhook on
1.26 - instead use the new `warden-mutating` webhook. I am following
up internally with finding a less brittle way to do this.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d26eced0-4410-4b8d-8bc0-c2fdb4e5e554

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3032/head:pr_3032 && git checkout pr_3032
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-8ccf940-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Mar 16, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we have unit test for this logic?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit 1725dfc into googleforgames:main Mar 16, 2023
zmerlynn added a commit that referenced this pull request Mar 16, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
chiayi pushed a commit to chiayi/agones that referenced this pull request Jun 1, 2023
The `workload-defaulter` no longer exists as a standalone webhook on
1.26 - instead use the new `warden-mutating` webhook. I am following
up internally with finding a less brittle way to do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants