-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GKE Autopilot auto-detection for 1.26 #3032
Conversation
The `workload-defaulter` no longer exists as a standalone webhook on 1.26 - instead use the new `warden-mutating` webhook. I am following up internally with finding a less brittle way to do this.
Build Succeeded 👏 Build Id: d26eced0-4410-4b8d-8bc0-c2fdb4e5e554 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we have unit test for this logic?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The `workload-defaulter` no longer exists as a standalone webhook on 1.26 - instead use the new `warden-mutating` webhook. I am following up internally with finding a less brittle way to do this.
The
workload-defaulter
no longer exists as a standalone webhook on 1.26 - instead use the newwarden-mutating
webhook. I am following up internally with finding a less brittle way to do this.