Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description on when to upgrade supported Kubernetes version #3049

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Mar 28, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: feb8ec4a-d593-4507-a70e-13bf9d7cc27d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3049/head:pr_3049 && git checkout pr_3049
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-9b4c353-amd64

@gongmax gongmax marked this pull request as ready for review March 29, 2023 17:21
@@ -39,7 +39,7 @@ For all the platforms in Alpha, we would appreciate testing and bug reports on a

## Agones and Kubernetes Supported Versions

Agones will support 3 releases of Kubernetes, targeting the newest version as being the [default version in the GKE Rapid channel](https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions). However, we will ensure that at least one of the 3 versions chosen for each Agones release is supported by each of the major cloud providers (EKS and AKS). The vendored version of client-go will be aligned with the middle of the three supported Kubernetes versions. When a new version of Agones supports new versions of Kubernetes, it is explicitly called out in the [release notes](https://agones.dev/site/blog/releases/).
Agones will support 3 releases of Kubernetes, targeting the newest version as being the [latest available version in the GKE Rapid channel](https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions). However, we will ensure that at least one of the 3 versions chosen for each Agones release is supported by each of the major cloud providers (EKS and AKS). The vendored version of client-go will be aligned with the middle of the three supported Kubernetes versions. When a new version of Agones supports new versions of Kubernetes, it is explicitly called out in the [release notes](https://agones.dev/site/blog/releases/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here feels very similar to the otther, should we consolidate on one place or the other to specify the version support policy? It seems like you link out to this doc above, seems reasonable to de-dupe to the agones site documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the other doc (the CONTRIBUTION.md) is more targeting to the contributor and maintainer of the project, while this Installation doc is facing to the user. So I'm hesitating to expose detailed information about the maintenance steps of version upgrade in this doc since user may and should not care about that.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 440aeb8b-9ab3-4d08-89d7-eab84cff6421

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 07ac7103-4f52-441c-80f8-6fbaf28c3635

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3049/head:pr_3049 && git checkout pr_3049
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-a1bca14-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Mar 31, 2023
@zmerlynn zmerlynn enabled auto-merge (squash) March 31, 2023 18:04
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: aed521e8-9b10-4b61-a51f-f30b81169c69

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 5, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 13e5c5d0-094b-4373-a1ed-a3799ce67298

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3049/head:pr_3049 && git checkout pr_3049
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-d073d64-amd64

@zmerlynn zmerlynn merged commit 1dbd4ee into googleforgames:main Apr 5, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/documentation Documentation for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
@gongmax gongmax deleted the fix_doc_2 branch April 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants