Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release tag on Unity SDK installation document page (#2622) #3071

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fix release tag on Unity SDK installation document page (#2622) #3071

merged 2 commits into from
Apr 5, 2023

Conversation

oniku-2929
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind feature
/kind hotfix

/kind documentation

What this PR does / Why we need it:
To fix invalid tag information on Unity SDK installation document page.
Also, it automatically increments the release tag based on the release version.

Which issue(s) this PR fixes:

Closes #2622

Special notes for your reviewer:
I checked on Unity 2021.3.16f1 Personal.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e7a5fd03-054a-44b8-b1ef-b45f2a38a4b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3071/head:pr_3071 && git checkout pr_3071
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-80c92ad-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an excellent catch!

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 5, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, oniku-2929, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Apr 5, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 257d4013-ea41-460b-a8e0-44829cdcccea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3071/head:pr_3071 && git checkout pr_3071
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-cac6ddc-amd64

@markmandel markmandel merged commit 4e2fe2c into googleforgames:main Apr 5, 2023
chiayi pushed a commit to chiayi/agones that referenced this pull request Apr 5, 2023
@oniku-2929 oniku-2929 deleted the issue/2622 branch April 6, 2023 00:38
@Kalaiselvi84 Kalaiselvi84 added the kind/documentation Documentation for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The version specification pattern in the Unity SDK installation document does not match the actual release tag
5 participants