Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples images to latest version on agones-images #3077

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Update examples images to latest version on agones-images #3077

merged 3 commits into from
Apr 7, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

…ks/go in go.sum

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 requested review from markmandel and removed request for aLekSer and roberthbailey April 6, 2023 22:00
markmandel
markmandel approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed - I got this one locally as well.

@markmandel
Copy link
Member

Just checking - Is this still in draft?

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review April 6, 2023 23:51
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 67a738d4-f12c-4fb9-92d8-4fa26432db37

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Kalaiselvi84 Kalaiselvi84 changed the title Update all examples to latest version on agones-images Update examples images to latest version on agones-images Apr 7, 2023
@Kalaiselvi84
Merge pull request #40 from Kalaiselvi84/main
02fb686 
Add tags for cluster, location, commit to e2e-test builds (googleforgames#3074)
@google-oss-prow google-oss-prow bot added the lgtm label Apr 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c8d54be3-47f7-4249-8d13-13a8aff6acd8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3077/head:pr_3077 && git checkout pr_3077
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-02fb686-amd64

@markmandel markmandel merged commit 8cae180 into googleforgames:main Apr 7, 2023
@markmandel markmandel deleted the issues/277239007 branch April 7, 2023 17:52
@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 added a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
@Kalaiselvi84
Update examples images to latest version on agones-images (googleforg…
00aef32 
…ames#3077)

* Ran  to add the missing module providing package agones.dev/agones/sdks/go in go.sum

* Latest version update for yaml and tf files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kalaiselvi84 @markmandel @agones-bot