Add to SplitControllerAndExtensions documentation for leader election #3083
Conversation
chiayi
requested review from
zmerlynn
and removed request for
EricFortin and
aLekSer
|
Build Failed 😱 Build Id: 5e0ddae5-13b2-4669-a45d-782f9283671e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 220e4616-1c28-4cd3-bac2-44e7f8db8ddd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| Leader election will automatically be enabled while `SplitControllerAndExtensions` is enabled and while `agones.controller.replicas` is set to > 1. The current default value for [`agones.controller.replicas`]({{< relref "/docs/Installation/Install Agones/helm.md#configuration" >}}) is 2. | ||
| {{% /feature %}} | ||
|
|
||
| When `SplitControllerAndExtensions` is enabled, what was previously a single `agones-controller` pod is deployed as {{% feature publishVersion="1.31.0" %}}, possibly 2+,{{% /feature %}} `agones-controller` and 2 `agones-extensions` pods. For example: |
There was a problem hiding this comment.
since you already have a publishVersion block here, just duplicate this paragraph to make it easier on the review rather than embedding a publish in the middle.
There was a problem hiding this comment.
Going to remove the publishVersion blocks since the release already started. I'm thinking we can merge this after the release is done.
zmerlynn
changed the title
|
Build Failed 😱 Build Id: 6d2c34b3-cdc6-4f93-9c2e-3c7f578e1b53 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 5a0eb727-1051-4288-88ca-70db4ce2a221 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| agones-ping-5b9647874-rksgg 1/1 Running 0 27h | ||
| ``` | ||
|
|
||
| Or if `agones.controller.replicas` > 1 |
There was a problem hiding this comment.
I would just show this list. I think this is over-focusing on replicas being modifiable and it's kind of a lot of real estate to devote - we have to assume the user has a working knowledge of k8s.
| When `SplitControllerAndExtensions` is enabled, what was previously a single `agones-controller` pod is deployed as `agones-controller` and 2 `agones-extensions` pods. For example: | ||
| Leader election will automatically be enabled when `SplitControllerAndExtensions` is enabled and `agones.controller.replicas` is > 1. [`agones.controller.replicas`]({{< relref "/docs/Installation/Install Agones/helm.md#configuration" >}}) defaults to 2. | ||
|
|
||
| When `SplitControllerAndExtensions` is enabled, what was previously a single `agones-controller` pod is deployed as , possibly 2+, `agones-controller` and 2 `agones-extensions` pods. For example: |
There was a problem hiding this comment.
as , possibly 2+,
just say 2. Both replica settings are changeable, so you don't need to say "possibly 2+". Maybe like this:
When `SplitControllerAndExtensions` is enabled, what was previously a single `agones-controller` pod is deployed by default as 2 `agones-controller` and 2 `agones-extensions` pods. For example:
…or leader election
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chiayi, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: c6502595-3461-4fae-8f67-36618eb5f1e8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Add documentation to
High Availability Agonesfor controller leader electionWhich issue(s) this PR fixes:
Work on #2797
Special notes for your reviewer: