Release Automation: Push images on cloud #3090

Kalaiselvi84 · 2023-04-12T21:28:03Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

markmandel

Looks really good!

Let's also take these step out of make do-release and this is probably good to go.

Unless we need to update the release checklist as well? You probably know this best at this point 👍🏻

agones/build/includes/release.mk

Lines 74 to 96 in 02e57ba

    
           do-release: RELEASE_VERSION ?= $(base_version) 
        
           do-release: $(ensure-build-image) 
        
           	@echo "Starting release for version: $(RELEASE_VERSION)" 
        
           	# switch to the right project 
        
           	$(DOCKER_RUN) gcloud config configurations activate agones-images 
        
           	git checkout -b release-$(RELEASE_VERSION) 
        
           	-rm -rf $(agones_path)/release 
        
           	mkdir $(agones_path)/release 
        
           	$(MAKE) -j 4 build VERSION=$(RELEASE_VERSION) REGISTRY=$(release_registry) FULL_BUILD=1 
        
           	cp $(agones_path)/cmd/sdk-server/bin/agonessdk-server-$(RELEASE_VERSION).zip $(agones_path)/release 
        
           	cp $(agones_path)/sdks/cpp/.archives/agonessdk-$(RELEASE_VERSION)-linux-arch_64.tar.gz $(agones_path)/release 
        
           	cd $(agones_path) &&  zip -r ./release/agones-install-$(RELEASE_VERSION).zip ./README.md ./install ./LICENSE 
        
           	$(MAKE) gcloud-auth-docker 
        
           	$(MAKE) -j 4 push REGISTRY=$(release_registry) VERSION=$(RELEASE_VERSION) 
        
           	$(MAKE) push-chart VERSION=$(RELEASE_VERSION) 
        
           	git push -u upstream release-$(RELEASE_VERSION) 
        
           	@echo "Now go make the $(RELEASE_VERSION) release on Github!"

build/release/cloudbuild.yaml

markmandel · 2023-04-12T21:32:59Z

build/release/cloudbuild.yaml

+    env:
+      - "VERSION=${_VERSION}"
+      - "REGISTRY=${_REGISTRY}/release"
+    args: ["-j", "1", "push"]


Could we do this in parrallel? (i.e. -j=4 (or whatever number is the best)? Maybe make things a bit faster?)

Kalaiselvi84 · 2023-04-12T21:47:19Z

$(MAKE) push-chart VERSION=$(RELEASE_VERSION)

This step is not required in cloud?

markmandel

Sorry - sent you a message offline - just realised I've sent you down the wrong path - my apologies.

Kalaiselvi84 · 2023-04-12T22:40:56Z

sent you a message offline

I am working on it..

agones-bot · 2023-04-12T22:42:06Z

Build Failed 😱

Build Id: f6fb36b5-ea4e-4fa3-a2be-b5f18714ff4c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

… steps separately

agones-bot · 2023-04-13T00:11:37Z

Build Failed 😱

Build Id: 044b212b-4382-4fbf-bc08-2fc86f1d6c48

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-14T02:28:26Z

Build Failed 😱

Build Id: 9d852352-3e52-4243-b402-876845080d63

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-14T19:59:58Z

Build Succeeded 👏

Build Id: 3aaac936-73fa-4e7b-b59f-d56dd5743829

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-6c2b7e1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-6c2b7e1-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-6c2b7e1-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-6c2b7e1-amd64
Linux C++ SDK (build): agonessdk-1.32.0-6c2b7e1-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-6c2b7e1-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6c2b7e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3090/head:pr_3090 && git checkout pr_3090
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-6c2b7e1-amd64

markmandel

Couple of small things, but this looks good 👍🏻

markmandel · 2023-04-14T23:27:55Z

build/includes/release.mk

-	cd $(agones_path) &&  zip -r ./release/agones-install-$(RELEASE_VERSION).zip ./README.md ./install ./LICENSE
-
-	$(MAKE) gcloud-auth-docker
-	$(MAKE) -j 4 push REGISTRY=$(release_registry) VERSION=$(RELEASE_VERSION)


Let's keep the target, but remove the building of the images and pushing them.

We still need to push the helm chart (which is being worked on), and also work out where to sort out the git branch work as well.

Included the do-release target with push-chart and git branch. Will work on the branch part along with push-chart target in b/278275965

markmandel · 2023-04-14T23:31:20Z

build/release/post_cloudbuild.yaml

@@ -0,0 +1,125 @@
+# Copyright 2021 Google LLC


New files, so

Suggested change

# Copyright 2021 Google LLC

# Copyright 2023 Google LLC

fixed it 👍🏻

agones-bot · 2023-04-15T03:33:22Z

Build Succeeded 👏

Build Id: 8de54efe-4b39-400a-88a7-3c5e9e83dd56

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-ffe1c86-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-ffe1c86-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-ffe1c86-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-ffe1c86-amd64
Linux C++ SDK (build): agonessdk-1.32.0-ffe1c86-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-ffe1c86-amd64.zip

A preview of the website (the last 30 builds are retained):

https://ffe1c86-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3090/head:pr_3090 && git checkout pr_3090
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-ffe1c86-amd64

google-oss-prow · 2023-04-18T08:40:48Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2023-04-18T08:40:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-04-18T09:29:35Z

Build Succeeded 👏

Build Id: 857e4ff2-201f-4d6c-813d-cd8d0892e9d3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-499c34e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-499c34e-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-499c34e-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-499c34e-amd64
Linux C++ SDK (build): agonessdk-1.32.0-499c34e-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-499c34e-amd64.zip

A preview of the website (the last 30 builds are retained):

https://499c34e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3090/head:pr_3090 && git checkout pr_3090
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-499c34e-amd64

make push step added in release/cloudbuild.yaml

09a55ba

google-oss-prow bot added the do-not-merge/work-in-progress label Apr 12, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey April 12, 2023 21:28

google-oss-prow bot added the size/L label Apr 12, 2023

Kalaiselvi84 requested a review from markmandel April 12, 2023 21:28

markmandel reviewed Apr 12, 2023

View reviewed changes

Removed make target for do-release

057cd08

markmandel reviewed Apr 12, 2023

View reviewed changes

Two make targets created in release.mk to execute the cloudbuild.yaml…

94f65d5

… steps separately

Cloud-specific steps were separated into two files

b4f00f2

Merge branch 'main' into pr-gcp

6c2b7e1

Kalaiselvi84 marked this pull request as ready for review April 14, 2023 18:16

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 14, 2023

google-oss-prow bot requested a review from EricFortin April 14, 2023 18:17

markmandel reviewed Apr 14, 2023

View reviewed changes

markmandel approved these changes Apr 18, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Apr 18, 2023

google-oss-prow bot added the lgtm label Apr 18, 2023

markmandel enabled auto-merge (squash) April 18, 2023 08:40

Merge branch 'main' into pr-gcp

499c34e

google-oss-prow bot removed the lgtm label Apr 18, 2023

google-oss-prow bot added the approved label Apr 18, 2023

markmandel disabled auto-merge April 18, 2023 14:32

markmandel merged commit 811afd8 into googleforgames:main Apr 18, 2023

markmandel deleted the pr-gcp branch April 18, 2023 14:32

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release Automation: Push images on cloud #3090

Release Automation: Push images on cloud #3090

Kalaiselvi84 commented Apr 12, 2023

markmandel left a comment

markmandel Apr 12, 2023

Kalaiselvi84 commented Apr 12, 2023

markmandel left a comment

Kalaiselvi84 commented Apr 12, 2023

agones-bot commented Apr 12, 2023

agones-bot commented Apr 13, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

markmandel left a comment

markmandel Apr 14, 2023

Kalaiselvi84 Apr 15, 2023

markmandel Apr 14, 2023

Kalaiselvi84 Apr 15, 2023

agones-bot commented Apr 15, 2023

google-oss-prow bot commented Apr 18, 2023

google-oss-prow bot commented Apr 18, 2023

agones-bot commented Apr 18, 2023

	do-release: RELEASE_VERSION ?= $(base_version)
	do-release: $(ensure-build-image)
	@echo "Starting release for version: $(RELEASE_VERSION)"

	# switch to the right project
	$(DOCKER_RUN) gcloud config configurations activate agones-images

	git checkout -b release-$(RELEASE_VERSION)
	-rm -rf $(agones_path)/release
	mkdir $(agones_path)/release

	$(MAKE) -j 4 build VERSION=$(RELEASE_VERSION) REGISTRY=$(release_registry) FULL_BUILD=1
	cp $(agones_path)/cmd/sdk-server/bin/agonessdk-server-$(RELEASE_VERSION).zip $(agones_path)/release
	cp $(agones_path)/sdks/cpp/.archives/agonessdk-$(RELEASE_VERSION)-linux-arch_64.tar.gz $(agones_path)/release
	cd $(agones_path) && zip -r ./release/agones-install-$(RELEASE_VERSION).zip ./README.md ./install ./LICENSE

	$(MAKE) gcloud-auth-docker
	$(MAKE) -j 4 push REGISTRY=$(release_registry) VERSION=$(RELEASE_VERSION)

	$(MAKE) push-chart VERSION=$(RELEASE_VERSION)
	git push -u upstream release-$(RELEASE_VERSION)

	@echo "Now go make the $(RELEASE_VERSION) release on Github!"

Release Automation: Push images on cloud #3090

Release Automation: Push images on cloud #3090

Conversation

Kalaiselvi84 commented Apr 12, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 12, 2023

Choose a reason for hiding this comment

Kalaiselvi84 commented Apr 12, 2023

markmandel left a comment

Choose a reason for hiding this comment

Kalaiselvi84 commented Apr 12, 2023

agones-bot commented Apr 12, 2023

agones-bot commented Apr 13, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 14, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Apr 15, 2023

Choose a reason for hiding this comment

markmandel Apr 14, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Apr 15, 2023

Choose a reason for hiding this comment

agones-bot commented Apr 15, 2023

google-oss-prow bot commented Apr 18, 2023

google-oss-prow bot commented Apr 18, 2023

agones-bot commented Apr 18, 2023