Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push-Chart to Helm Repo on GCS #3114

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Apr 20, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.32.0 milestone Apr 20, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 942fd1e2-64a8-42b8-8dd3-537ca649bc77

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3114/head:pr_3114 && git checkout pr_3114
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-348034c-amd64

build/Makefile Outdated
@@ -282,7 +282,7 @@ build-chart: $(ensure-build-image)

# push the current chart to google cloud storage and update the index
push-chart: $(ensure-build-image) build-chart
docker run --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \
docker run --network=cloudbuild --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set this up the same as we have other targets, so have it as:

Suggested change
docker run --network=cloudbuild --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \
docker run $(DOCKER_RUN_ARGS) --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \

And then pass in the --network=cloudbuild from the post_cloudbuild.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it done.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 76884993-521c-45f6-adfc-a3048747d26b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3114/head:pr_3114 && git checkout pr_3114
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-166d5dd-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dd1dcd77-5a14-4dc6-b2ba-65ede7571fe4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3114/head:pr_3114 && git checkout pr_3114
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-e75d89d-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, Kalaiselvi84
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit 0064c14 into googleforgames:main Apr 21, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the issues/278275965 branch March 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants