-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameServerAllocation Actions for Counters and Lists #3117
GameServerAllocation Actions for Counters and Lists #3117
Conversation
Build Failed 😱 Build Id: 5ea405c7-43d5-422d-ae10-2559e5a52c6d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
f826c50
to
701104f
Compare
Build Failed 😱 Build Id: 573c1916-fb84-4982-99f3-42fa9cd17a34 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
701104f
to
2473604
Compare
Build Succeeded 👏 Build Id: f3453cfa-1e22-4960-ae1d-0df619aa7a2d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
2473604
to
8ca5bd0
Compare
8ca5bd0
to
13d6d36
Compare
Build Failed 😱 Build Id: 7edff056-7941-4c63-8d4b-94bf8c498b56 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 7b20f149-aad9-4df7-b6cb-627ad5f56119 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
6247dba
to
865a17b
Compare
Build Failed 😱 Build Id: e6fbb9c2-8418-4d1f-9bae-9a4b8d8291bf To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 1af811ba-a38a-4ddc-89cf-8e668150ca97 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 6d58ce84-088f-4271-8835-08970663ec5d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
5750c4d
to
642f466
Compare
Build Failed 😱 Build Id: 4669b8cd-ef2b-462b-8260-575ec120929d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
642f466
to
4fb3162
Compare
Build Failed 😱 Build Id: ce5596cc-491e-4d3b-8880-6e64d9754f0d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, igooch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 28e88068-b3c0-4672-842a-975ef4f8f892 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: e93a479e-7978-4fa4-9e5d-214158c3ead1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 548331c0-2d2c-4d3d-8059-ade57f5da6fa To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 61f50861-126b-452d-9d9e-515eb7d9e18a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
420dd4d
to
8f6ccdd
Compare
Build Failed 😱 Build Id: 56dd5158-40e5-4d21-894c-79bfdc742163 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 62327789-5770-4104-87ad-fcd0cb480e22 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: a678af2a-fc50-42c5-8ebe-a1e6b8db3947 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: a9e20eb2-8f35-4145-a6ac-cdd492705b87 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
8f6ccdd
to
0ef99cf
Compare
Build Failed 😱 Build Id: e508cbbc-2a72-4b3b-9356-d310a8278863 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 94e31b55-6897-467e-b589-0fdacc5bdb8b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
… any counter or list actions as warning events
0ef99cf
to
6296d8f
Compare
Build Succeeded 👏 Build Id: 8076a0cf-802b-40ad-b0cc-7ce375a00f19 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
) * Counts and Lists Actions on Game Server Allocation * Adds test for findGameServerForAllocation * Updates ListAction field to avoid pointer to a list * Generated Files * Moves counter and list action kick to the Allocator.goAdds logging of any counter or list actions as warning events * Updates actions to return single error * Move event recording after successful game server update
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Allows for below possible actions at Game Server Allocation:
Any actions that cannot be performed are no-op, and a warning that there was a no-op gets logged as an event.
An action may be partially completed, i.e. a Counter capacity could be updated, but an increment of the Counter is unable to be performed.
Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer: