-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require.NoError in fleet tests instead of continuing #3124
Conversation
When the fleet tests flake, they take out the rest of the test suite: ``` Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s) Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered] Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 ``` Looking at this file, it's easy to see why: if there's every an error from any of these asserts, we just continue with the test and assume the fleet is valid. But it's not.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: 5d8cd35e-9ce3-4ea0-89bc-d0a41869054b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 36320fa6-5385-4535-99de-9a438ef5a4a6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
When the fleet tests flake, they take out the rest of the test suite: