Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a static NodePort for the ping service #3148

Merged
merged 3 commits into from
May 20, 2023
Merged

Allow setting a static NodePort for the ping service #3148

merged 3 commits into from
May 20, 2023

Conversation

towolf
Copy link
Contributor

@towolf towolf commented May 12, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Similar to the allocator service, which allows setting static nodePorts, we added the same thing to the ping service, which will benefit from having a predictable static NodePort. This is for clusters which do not have access to Service Type: LoadBalancer.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 899f9158-29fc-43e2-b915-463277d98e12

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn
zmerlynn reviewed May 17, 2023
View reviewed changes
install/helm/agones/values.yaml
@@ -137,6 +137,7 @@ agones:
expose: true
response: ok
port: 80
nodePort: 0 # nodePort will be used if the serviceType is set to NodePort
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation in https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Installation/Install%20Agones/helm.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to get this in, then I'll handle this after this is merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was offline for a week. Totally missed this.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0fbb00db-105f-4092-aa54-69e032a095ff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3148/head:pr_3148 && git checkout pr_3148
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-e11f550-amd64

@google-oss-prow google-oss-prow bot added the lgtm label May 19, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: towolf, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) May 19, 2023 20:19
zmerlynn added a commit to zmerlynn/agones that referenced this pull request May 19, 2023
@zmerlynn
Add docs for googleforgames#3148
9fb82ba
@zmerlynn zmerlynn mentioned this pull request May 19, 2023
Merged
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: da6232c5-1ca0-4c32-953a-8979073ddc26

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot removed the lgtm label May 19, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7611a708-c123-4f45-a17c-5b55c047b9a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3148/head:pr_3148 && git checkout pr_3148
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-9fdcc92-amd64

@zmerlynn zmerlynn merged commit b944971 into googleforgames:main May 20, 2023
roberthbailey added a commit that referenced this pull request May 22, 2023
@zmerlynn @gongmax @roberthbailey
Add docs for #3148 (#3173)
fff27cd 
Co-authored-by: Mengye (Max) Gong <8364575+gongmax@users.noreply.github.com>
Co-authored-by: Robert Bailey <robertbailey@google.com>
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@zmerlynn zmerlynn

Labels
kind/feature New features for Agones size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@towolf @agones-bot @zmerlynn @Kalaiselvi84