[Release Automation] Label PRs with GitHub Action #3151

Kalaiselvi84 · 2023-05-12T20:23:42Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind feature
What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2459

Special notes for your reviewer:

Kalaiselvi84 · 2023-05-12T20:34:39Z

@zmerlynn,

Github action failed to label the PR due to resource not accessible by integration. Is there any permission required to access the files?

agones-bot · 2023-05-12T21:34:28Z

Build Failed 😱

Build Id: 6bc8522d-0bdd-48cd-8303-ac00805cfa39

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-17T00:56:59Z

Build Failed 😱

Build Id: 4924d90f-1c38-4a7c-9438-b4b6e22ddcfc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-18T02:25:33Z

Build Succeeded 👏

Build Id: 14d0d643-9eb7-42c5-9f09-74eae847d2a5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-0f04029-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-0f04029-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-0f04029-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-0f04029-amd64
Linux C++ SDK (build): agonessdk-1.32.0-0f04029-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-0f04029-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0f04029-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3151/head:pr_3151 && git checkout pr_3151
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-0f04029-amd64

…ones into issues/280492287

agones-bot · 2023-05-19T19:12:50Z

Build Succeeded 👏

Build Id: b0c95a53-29df-4552-9873-24ea8918aecc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-7d65f08-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-7d65f08-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-7d65f08-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-7d65f08-amd64
Linux C++ SDK (build): agonessdk-1.32.0-7d65f08-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-7d65f08-amd64.zip

A preview of the website (the last 30 builds are retained):

https://7d65f08-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3151/head:pr_3151 && git checkout pr_3151
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-7d65f08-amd64

agones-bot · 2023-05-25T18:31:46Z

Build Failed 😱

Build Id: 04e77449-b426-4f01-b133-6c4d122ddf74

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-05-31T06:56:10Z

.github/workflows/label-pr.yml

+        uses: actions/github-script@v4
+        with:
+          async: yes
+          repo-token: ${{ secrets.GITHUB_TOKEN }}


What happens if you use the AGONES_BOT secret?

I attempted to use AGONES_BOT by creating a secret with that name in my repo and it is functioning as intended - https://github.com/Kalaiselvi84/agones/actions/runs/5133792952/jobs/9236886161?pr=262

Let's take that for a spin, see how it goes.

I created a new PR to test this script, but it did not receive any labels. Instead, I encountered an error message stating, "Error retrieving files: HttpError: Resource not accessible by integration." - https://github.com/googleforgames/agones/actions/runs/5140174858/jobs/9251379449?pr=3194

That's weird. So it worked once but not a second time?

Should we just merge it and see what happens on the Agones repo? Any downside?

It is working fine in my fork every time but fails in Agones.

My fork - https://github.com/Kalaiselvi84/agones/actions/runs/5133792952/jobs/9236886161?pr=262
Agones repo - https://github.com/googleforgames/agones/actions/runs/5140174858/jobs/9251379449?pr=3194

Should we just merge it and see what happens on the Agones repo? Any downside?

I am unsure about the Github Action script's functionality, given our prior experience with the "update branch" task. While it worked smoothly in our fork, it encountered issues when applied to Agones.

Do we need to configure permissions for AGONES_BOT in order to resolve the error encountered in the Agones repository: 'Error retrieving files: HttpError: Resource not accessible by integration'?

agones-bot · 2023-05-31T19:47:26Z

Build Failed 😱

Build Id: 20ec9c47-7435-4891-8885-7437dd54dab9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-06-01T02:33:21Z

Build Succeeded 👏

Build Id: 6ff4f47e-4461-4ab3-8558-c8dbe2cb2592

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-754f665-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-754f665-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-754f665-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-754f665-amd64
Linux C++ SDK (build): agonessdk-1.33.0-754f665-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-754f665-amd64.zip

A preview of the website (the last 30 builds are retained):

https://754f665-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3151/head:pr_3151 && git checkout pr_3151
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-754f665-amd64

agones-bot · 2023-06-01T04:39:23Z

Build Succeeded 👏

Build Id: 9c718437-d6cf-4e52-a8ce-baf799ce33f3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-3727d4d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-3727d4d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-3727d4d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-3727d4d-amd64
Linux C++ SDK (build): agonessdk-1.33.0-3727d4d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-3727d4d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://3727d4d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3151/head:pr_3151 && git checkout pr_3151
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-3727d4d-amd64

code changed since last review

markmandel · 2023-06-01T07:40:45Z

.github/workflows/label-pr.yml

+      pull-requests: write
+
+    steps:
+      - name: Checkout code


Curious - do we need to check out the repository code?

This line is not required. I included it to ensure that the workflow can access the files to avoid the integration issue, but still the error persists so will remove it

markmandel · 2023-06-01T07:41:23Z

.github/workflows/label-pr.yml

+        with:
+          async: yes
+          repo-token: ${{ secrets.AGONES_BOT }}
+          script: |


It's super cool you can do this.

agones-bot · 2023-06-01T16:30:54Z

Build Failed 😱

Build Id: 8039a281-dd7f-4fb9-9497-cf10ff8f61d1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-06-02T00:25:02Z

.github/workflows/label-pr.yml

+    permissions:
+      pull-requests: write


Suggested change

permissions:

pull-requests: write

permissions:

contents: read

pull-requests: write

Possibly? Just taking reference from: https://github.com/actions/labeler#create-workflow

It's also possible to try it with the GITHUB_TOKEN

Or try permissions: read-all|write-all as mentioned in https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions, just to see if it's a permissions issue.

@markmandel, please merge this PR. I was able to reproduce the error in my fork by not adding the write permission to the pull_request and issues - https://github.com/Kalaiselvi84/agones/actions/runs/5185413754/jobs/9345294118?pr=274
You can adjust the permission in Agones if there is any issues. WDYT?

Sounds good! Merging!

agones-bot · 2023-06-06T17:28:08Z

Build Failed 😱

Build Id: 741a8bf2-06b7-4aad-85ab-6c2ef0d6e7cc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-06-06T18:28:24Z

Build Succeeded 👏

Build Id: f3da7a13-d54d-4264-9d05-fd502aff2d26

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.33.0-e02934b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.33.0-e02934b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.33.0-e02934b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.33.0-e02934b-amd64
Linux C++ SDK (build): agonessdk-1.33.0-e02934b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.33.0-e02934b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://e02934b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3151/head:pr_3151 && git checkout pr_3151
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-e02934b-amd64

google-oss-prow · 2023-06-07T20:28:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Release Automation] Auto-Label PRs with GitHub Action

47e93f4

google-oss-prow bot added the size/M label May 12, 2023

google-oss-prow bot requested review from aLekSer and roberthbailey May 12, 2023 20:24

Kalaiselvi84 marked this pull request as draft May 12, 2023 20:25

google-oss-prow bot added the do-not-merge/work-in-progress label May 12, 2023

Kalaiselvi84 requested a review from zmerlynn May 12, 2023 20:33

Kalaiselvi84 changed the title ~~[Release Automation] Auto-Label PRs with GitHub Action~~ [Release Automation] Label PRs with GitHub Action May 12, 2023

Kalaiselvi84 marked this pull request as ready for review May 13, 2023 00:10

google-oss-prow bot removed the do-not-merge/work-in-progress label May 13, 2023

google-oss-prow bot requested a review from EricFortin May 13, 2023 00:10

copyright and description added

7542f99

google-oss-prow bot added size/L and removed size/M labels May 16, 2023

Kalaiselvi84 added 2 commits May 17, 2023 16:42

[Release Automation] Auto-Label PRs with GitHub Action

40d532f

copyright and description added

0f04029

zmerlynn force-pushed the issues/280492287 branch from 7542f99 to 0f04029 Compare May 17, 2023 23:42

Kalaiselvi84 added 3 commits May 19, 2023 16:23

Merge branch 'main' into issues/280492287

1c5ee77

Merge branch 'issues/280492287' of https://github.com/Kalaiselvi84/ag…

c5dc5c8

…ones into issues/280492287

removed measuring size of code

7d65f08

google-oss-prow bot added size/M and removed size/L labels May 19, 2023

Kalaiselvi84 marked this pull request as draft May 19, 2023 19:57

google-oss-prow bot added the do-not-merge/work-in-progress label May 19, 2023

Merge branch 'main' into issues/280492287

21a5441

Kalaiselvi84 requested a review from markmandel May 30, 2023 16:29

markmandel reviewed May 31, 2023

View reviewed changes

Kalaiselvi84 added 2 commits May 31, 2023 16:29

Merge branch 'main' into issues/280492287

7cbb806

Replacing GITHUB_TOKEN with AGONES_BOT

754f665

Merge branch 'main' into issues/280492287

3727d4d

Kalaiselvi84 marked this pull request as ready for review June 1, 2023 03:45

google-oss-prow bot removed the do-not-merge/work-in-progress label Jun 1, 2023

google-oss-prow bot requested a review from markmandel June 1, 2023 03:45

markmandel reviewed Jun 1, 2023

View reviewed changes

markmandel mentioned this pull request Jun 1, 2023

test-labeler #3194

Closed

Checkout code step removed

fcbe860

markmandel reviewed Jun 2, 2023

View reviewed changes

optimistic for the success

5eef6fc

Merge branch 'main' into issues/280492287

e02934b

markmandel approved these changes Jun 7, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Jun 7, 2023

google-oss-prow bot added the lgtm label Jun 7, 2023

google-oss-prow bot added the approved label Jun 7, 2023

markmandel merged commit 0b6de4a into googleforgames:main Jun 7, 2023

Kalaiselvi84 added the kind/feature New features for Agones label Jul 5, 2023

Kalaiselvi84 deleted the issues/280492287 branch March 15, 2024 01:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release Automation] Label PRs with GitHub Action #3151

[Release Automation] Label PRs with GitHub Action #3151

Kalaiselvi84 commented May 12, 2023 •

edited

Loading

Kalaiselvi84 commented May 12, 2023

agones-bot commented May 12, 2023

agones-bot commented May 17, 2023

agones-bot commented May 18, 2023

agones-bot commented May 19, 2023

agones-bot commented May 25, 2023

markmandel May 31, 2023

Kalaiselvi84 May 31, 2023 •

edited

Loading

markmandel Jun 1, 2023

Kalaiselvi84 Jun 1, 2023

markmandel Jun 1, 2023

Kalaiselvi84 Jun 1, 2023

agones-bot commented May 31, 2023

agones-bot commented Jun 1, 2023

agones-bot commented Jun 1, 2023

markmandel Jun 1, 2023

Kalaiselvi84 Jun 1, 2023

markmandel Jun 1, 2023

agones-bot commented Jun 1, 2023

markmandel Jun 2, 2023

zmerlynn Jun 2, 2023 •

edited

Loading

Kalaiselvi84 Jun 7, 2023

markmandel Jun 7, 2023

agones-bot commented Jun 6, 2023

agones-bot commented Jun 6, 2023

google-oss-prow bot commented Jun 7, 2023

[Release Automation] Label PRs with GitHub Action #3151

[Release Automation] Label PRs with GitHub Action #3151

Conversation

Kalaiselvi84 commented May 12, 2023 • edited Loading

Kalaiselvi84 commented May 12, 2023

agones-bot commented May 12, 2023

agones-bot commented May 17, 2023

agones-bot commented May 18, 2023

agones-bot commented May 19, 2023

agones-bot commented May 25, 2023

Choose a reason for hiding this comment

Kalaiselvi84 May 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented May 31, 2023

agones-bot commented Jun 1, 2023

agones-bot commented Jun 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Jun 1, 2023

Choose a reason for hiding this comment

zmerlynn Jun 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Jun 6, 2023

agones-bot commented Jun 6, 2023

google-oss-prow bot commented Jun 7, 2023

Kalaiselvi84 commented May 12, 2023 •

edited

Loading

Kalaiselvi84 May 31, 2023 •

edited

Loading

zmerlynn Jun 2, 2023 •

edited

Loading